Skip to content

docs(website): propagate typescript options to eslint #4773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 9, 2022
Merged

docs(website): propagate typescript options to eslint #4773

merged 4 commits into from
Apr 9, 2022

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Apr 1, 2022

PR Checklist

Overview

Use current typescript options for eslint processing

@nx-cloud
Copy link

nx-cloud bot commented Apr 1, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b1fff9a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 from NxCloud.

@typescript-eslint

This comment was marked as resolved.

Sign in to view
@netlify
Copy link

netlify bot commented Apr 1, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit b1fff9a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/625068243d15550008f8ff1a
😎 Deploy Preview https://deploy-preview-4773--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 1, 2022 •
edited
Loading

Codecov Report

Merging #4773 (db11109) into main (c59d9d7) will decrease coverage by 2.55%.
The diff coverage is 100.00%.

❗ Current head db11109 differs from pull request most recent head b1fff9a. Consider uploading reports for the commit b1fff9a to get more accurate results

@@            Coverage Diff             @@
##             main    #4773      +/-   ##
==========================================
- Coverage   94.28%   91.73%   -2.56%     
==========================================
  Files         151      355     +204     
  Lines        8208    11987    +3779     
  Branches     2670     3482     +812     
==========================================
+ Hits         7739    10996    +3257     
- Misses        261      654     +393     
- Partials      208      337     +129
Flag Coverage Δ
unittest 91.73% <100.00%> (-2.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../eslint-plugin/src/rules/method-signature-style.ts 89.15% <100.00%> (+0.26%) ⬆️
packages/scope-manager/src/lib/es2017.full.ts 100.00% <0.00%> (ø)
packages/utils/src/ast-utils/misc.ts 66.66% <0.00%> (ø)
...ckages/typescript-estree/src/jsx/xhtml-entities.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2020.promise.ts 100.00% <0.00%> (ø)
packages/type-utils/src/propertyTypes.ts 90.90% <0.00%> (ø)
packages/scope-manager/src/lib/esnext.string.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2017.object.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2021.string.ts 100.00% <0.00%> (ø)
...ages/scope-manager/src/lib/es2016.array.include.ts 100.00% <0.00%> (ø)
... and 195 more

@armano2 armano2 added the package: website Issues related to the @typescript-eslint website label Apr 1, 2022
@armano2 armano2 self-assigned this Apr 1, 2022
@armano2 armano2 changed the title fix(website): propagate typescript options to eslint #4767 fix(website): propagate typescript options to eslint Apr 2, 2022
JoshuaKGoldberg
JoshuaKGoldberg reviewed Apr 2, 2022
View reviewed changes
packages/website/src/components/editor/LoadedEditor.tsx
jsx,
sandboxInstance,
webLinter,
JSON.stringify(tsConfig) /* todo: better way? */,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, https://github.com/kentcdodds/use-deep-compare-effect ?

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Apr 3, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Word, thanks!

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) April 8, 2022 16:51
@bradzacher bradzacher disabled auto-merge April 9, 2022 00:11
@bradzacher bradzacher changed the title fix(website): propagate typescript options to eslint docs(website): propagate typescript options to eslint Apr 9, 2022
@bradzacher bradzacher merged commit 4c428c5 into main Apr 9, 2022
@bradzacher bradzacher deleted the fix/4767-playground-update-ts-options-in-eslint branch April 9, 2022 00:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

Assignees

@armano2 armano2

Labels
package: website Issues related to the @typescript-eslint website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Playground: options defined in config are not propagated to editor
3 participants
@armano2 @JoshuaKGoldberg @bradzacher