Skip to content

docs: remove duplicate period in method-signature-style #4849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2022
Merged

docs: remove duplicate period in method-signature-style #4849

merged 1 commit into from
Apr 23, 2022

Conversation

ybiquitous
Copy link
Contributor

PR Checklist

Overview

I believe this is just a typo.

@nx-cloud
Copy link

nx-cloud bot commented Apr 23, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ccd6997. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 43 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ybiquitous!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Apr 23, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ccd6997
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/626362ee3c03e20008edaf3c
😎 Deploy Preview https://deploy-preview-4849--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ybiquitous ybiquitous marked this pull request as draft April 23, 2022 02:11
@ybiquitous ybiquitous marked this pull request as ready for review April 23, 2022 02:23
@codecov
Copy link

codecov bot commented Apr 23, 2022

Codecov Report

Merging #4849 (ccd6997) into main (88ed9ec) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4849   +/-   ##
=======================================
  Coverage   94.23%   94.24%           
=======================================
  Files         152      152           
  Lines        8281     8282    +1     
  Branches     2694     2695    +1     
=======================================
+ Hits         7804     7805    +1     
  Misses        263      263           
  Partials      214      214           
Flag Coverage Δ
unittest 94.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../eslint-plugin/src/rules/method-signature-style.ts 89.15% <ø> (ø)
...ges/eslint-plugin/src/rules/no-misused-promises.ts 98.25% <100.00%> (ø)
packages/eslint-plugin/src/rules/no-namespace.ts 100.00% <100.00%> (ø)

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 5ad70db into typescript-eslint:main Apr 23, 2022
@ybiquitous ybiquitous deleted the patch-1 branch April 23, 2022 04:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants