Skip to content

feat: remove semantically invalid properties from TSEnumDeclaration, TSInterfaceDeclaration and TSModuleDeclaration #4863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 26, 2022
Merged

feat: remove semantically invalid properties from TSEnumDeclaration, TSInterfaceDeclaration and TSModuleDeclaration #4863

merged 5 commits into from
Oct 26, 2022

Conversation

juank1809
Copy link
Contributor

@juank1809 juank1809 commented Apr 25, 2022 •
edited by bradzacher
Loading

BREAKING CHANGE:
Removes properties from AST node types.

PR Checklist

Overview

Remove incorrect and useless properties from the AST nodes as we are not erroring this kind of semantically code; additionally removed one deprecated function in the converter file that used unsuitable modifiers for TSModuleDeclaration, TSEnumDeclaration and TSInterfaceDeclaration and instead used the utility hasModifier function to handle the const and declare properties when we are analyzing these typescript AST nodes.

The only code I trace using these invalid properties outside the typescript-estree package was in the scope-manager handling wrong interface inheritance.
Some snapshots were re-written as expected.

@nx-cloud
Copy link

nx-cloud bot commented Apr 25, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a69faeb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @juank1809!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Apr 25, 2022 •
edited
Loading

❌ Deploy Preview for typescript-eslint failed.

Name Link
🔨 Latest commit 7ca78b1
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62850820c3448b0008178113

@codecov
Copy link

codecov bot commented Apr 25, 2022 •
edited
Loading

Codecov Report

Merging #4863 (a69faeb) into v6 (04488c2) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##               v6    #4863      +/-   ##
==========================================
- Coverage   91.36%   91.34%   -0.03%     
==========================================
  Files         364      364              
  Lines       12143    12125      -18     
  Branches     3543     3540       -3     
==========================================
- Hits        11095    11076      -19     
- Misses        748      749       +1     
  Partials      300      300
Flag Coverage Δ
unittest 91.34% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/scope-manager/src/referencer/TypeVisitor.ts 98.98% <ø> (+0.98%) ⬆️
packages/typescript-estree/src/convert.ts 97.59% <100.00%> (-0.32%) ⬇️

@bradzacher bradzacher added the breaking change This change will require a new major version to be released label Apr 27, 2022
@bradzacher bradzacher added this to the 6.0.0 milestone Apr 27, 2022
@bradzacher bradzacher changed the title Semantically bad properties feat: remove semantically invalid properties from TSEnumDeclaration, TSInterfaceDeclaration and TSModuleDeclaration Apr 27, 2022
@bradzacher bradzacher added the AST PRs and Issues about the AST structure label Apr 27, 2022
@armano2
Copy link
Collaborator

armano2 commented May 10, 2022

can you remove Modifiers from ast types?

@bradzacher bradzacher changed the base branch from main to v6 October 26, 2022 01:42
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this @juank1809!

We're starting work on v6 now, so I'll merge this into the v6 branch. Woop!

@JoshuaKGoldberg JoshuaKGoldberg merged commit cf2956f into typescript-eslint:v6 Oct 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@bradzacher bradzacher Awaiting requested review from bradzacher

Assignees
No one assigned
Labels
AST PRs and Issues about the AST structure breaking change This change will require a new major version to be released
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

Remove properties that are used by invalid code
4 participants
@juank1809 @armano2 @JoshuaKGoldberg @bradzacher