docs(website): correct theme color blink when playground is initialized #4870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Josh-Cena
reviewed
Apr 27, 2022
| @@ -34,6 +35,7 @@ export const useSandboxServices = ( | |||
| ): Error | SandboxServices | undefined => { | |||
| const [services, setServices] = useState<Error | SandboxServices>(); | |||
| const [loadedTs, setLoadedTs] = useState<string>(props.ts); | |||
| const { isDarkTheme } = useColorMode(); | |||
There was a problem hiding this comment.
isDarkTheme is deprecated—you should see a warning in the console in development (it probably is not transparent enough, considering most people don't develop with their consoles open all the time). You should use const { colorMode } = useColorMode() instead
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview