Add eslint-recommended #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not to be a pain, but please use JSON instead of YAML. You could alternately use .js considering you want comments |
|
I changed it to .js! |
|
I'm an idiot, should have said - make it You will have to import it in |
Codecov Report
@@ Coverage Diff @@
## master #488 +/- ##
==========================================
- Coverage 95.81% 95.76% -0.06%
==========================================
Files 77 78 +1
Lines 3489 3491 +2
Branches 963 963
==========================================
Hits 3343 3343
- Misses 51 53 +2
Partials 95 95
|
|
I have changed the file to |
bradzacher
approved these changes
May 6, 2019
mysticatea
reviewed
May 7, 2019
teppeis
reviewed
May 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #477.
This PR adds a modifier for Typescript of
eslint-recommended. It has its separate file, such that it andplugin:@typescript-eslint/recommendedcan be used independently. I have included reasoning for the rules in the configuration.The goal of this configuration is to modify the recommended set of
eslintrules to be usable with Typescript. This means excluding those rules that are already tested by the compiler, and including additional rules for idiomatic code that is always available in Typescript.