Skip to content

chore: removed noUnused(Locals|Parameters) from tsconfig.base.json #4882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2022
Merged

chore: removed noUnused(Locals|Parameters) from tsconfig.base.json #4882

merged 2 commits into from
May 2, 2022

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

As the issue suggests, has us use the ESLint rule only.

@nx-cloud
Copy link

nx-cloud bot commented Apr 29, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 090bf49. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Apr 29, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 090bf49
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/626c2089db5b0d0008dcdbb6
😎 Deploy Preview https://deploy-preview-4882--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 29, 2022 •
edited
Loading

Codecov Report

Merging #4882 (090bf49) into main (f3cf87b) will increase coverage by 2.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4882      +/-   ##
==========================================
+ Coverage   91.77%   93.95%   +2.17%     
==========================================
  Files         227      174      -53     
  Lines       10611     9903     -708     
  Branches     3283     3136     -147     
==========================================
- Hits         9738     9304     -434     
+ Misses        591      354     -237     
+ Partials      282      245      -37
Flag Coverage Δ
unittest 93.95% <100.00%> (+2.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/configs/all.ts 100.00% <ø> (ø)
packages/eslint-plugin/src/rules/comma-spacing.ts 100.00% <100.00%> (ø)
...slint-plugin/src/rules/no-duplicate-enum-values.ts 100.00% <100.00%> (ø)
packages/type-utils/src/getTypeName.ts
packages/utils/src/eslint-utils/RuleTester.ts
...s/utils/src/ast-utils/eslint-utils/astUtilities.ts
packages/utils/src/eslint-utils/RuleCreator.ts
packages/utils/src/ts-eslint-scope/Variable.ts
packages/type-utils/src/isTypeReadonly.ts
...utils/src/ast-utils/eslint-utils/PatternMatcher.ts
... and 47 more

@bradzacher bradzacher merged commit 58d434a into typescript-eslint:main May 2, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the tsconfig-base-no-unused branch May 2, 2022 10:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[monorepo] Remove "noUnusedLocals" and "noUnusedParameters" from "tsconfig.base.json"
2 participants
@JoshuaKGoldberg @bradzacher