Skip to content

chore(website): update report as issue to use new issue forms #4916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2022

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented May 6, 2022

PR Checklist

Overview

@armano2 armano2 added enhancement New feature or request package: website Issues related to the @typescript-eslint website labels May 6, 2022
@nx-cloud
Copy link

nx-cloud bot commented May 6, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 57e3313. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@armano2 armano2 changed the title feat(website): update report as issue to use new issue forms #4913 feat(website): update report as issue to use new issue forms May 6, 2022
@netlify
Copy link

netlify bot commented May 6, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 57e3313
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62854ecbb1f0250008f643f6
😎 Deploy Preview https://deploy-preview-4916--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bradzacher bradzacher added the blocked by another PR PRs which are ready to go but waiting on another PR label May 6, 2022
@armano2 armano2 removed the blocked by another PR PRs which are ready to go but waiting on another PR label May 10, 2022
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I played around with it and it works great!

@bradzacher bradzacher changed the title feat(website): update report as issue to use new issue forms chore(website): update report as issue to use new issue forms May 23, 2022
@bradzacher bradzacher merged commit 1e1e85e into main May 23, 2022
@bradzacher bradzacher deleted the feat/playground-issue-forms-4913 branch May 23, 2022 17:50
bradzacher added a commit that referenced this pull request May 31, 2022
I was wrong [when I originally told armano to remove these](#4916 (comment)).
It appears that GH uses the issue form config to power the initial link from the issue chooser, and then completely ignores the config after that 😢 
So without this param, the issue is filled without any tags at all!!!
bradzacher added a commit that referenced this pull request Jun 1, 2022
* chore(website): include labels in the report-an-issue button

I was wrong [when I originally told armano to remove these](#4916 (comment)).
It appears that GH uses the issue form config to power the initial link from the issue chooser, and then completely ignores the config after that 😢 
So without this param, the issue is filled without any tags at all!!!

* Update packages/website/src/components/lib/markdown.ts

Co-authored-by: Armano <armano2@users.noreply.github.com>

Co-authored-by: Armano <armano2@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request package: website Issues related to the @typescript-eslint website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website: add a "report an issue" button on the playground
3 participants