test: correct execution of test and dev scripts on Windows machines #4926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #4926 +/- ##
==========================================
- Coverage 94.25% 91.78% -2.48%
==========================================
Files 153 226 +73
Lines 8305 10626 +2321
Branches 2702 3289 +587
==========================================
+ Hits 7828 9753 +1925
- Misses 263 591 +328
- Partials 214 282 +68
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bradzacher
reviewed
May 10, 2022
|
@bradzacher updated, after further investigation, glob/globby (most likely fast-glob) is no longer working correctly when path has mixed slash and backslash on windows machines, I fixed that by use of cwd and absolute param |
bradzacher
approved these changes
May 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
On Windows machines, allow tests to be executed, and correct issues with
prebuildscript