Skip to content

chore: removed commitlint #4981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 30, 2022
Merged

chore: removed commitlint #4981

merged 3 commits into from
May 30, 2022

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Removes the commitlint package and lines that reference it.

Also removes commitizen and cz-conventional-changelog. I don't see anything still using them?

@nx-cloud
Copy link

nx-cloud bot commented May 15, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3038f95. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented May 15, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 3038f95
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6293a4e04840ad00087fd95a
😎 Deploy Preview https://deploy-preview-4981--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented May 15, 2022 •
edited
Loading

Codecov Report

Merging #4981 (3038f95) into main (dc58ff5) will increase coverage by 0.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4981      +/-   ##
==========================================
+ Coverage   91.32%   91.70%   +0.38%     
==========================================
  Files         132      362     +230     
  Lines        1487    12181   +10694     
  Branches      224     3530    +3306     
==========================================
+ Hits         1358    11171    +9813     
- Misses         65      661     +596     
- Partials       64      349     +285
Flag Coverage Δ
unittest 91.70% <ø> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/typescript-estree/src/create-program/shared.ts 88.09% <0.00%> (ø)
...es/eslint-plugin/src/rules/no-array-constructor.ts 100.00% <0.00%> (ø)
...c/rules/no-non-null-asserted-nullish-coalescing.ts 91.66% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/prefer-includes.ts 97.72% <0.00%> (ø)
...-plugin/src/rules/explicit-function-return-type.ts 100.00% <0.00%> (ø)
...slint-plugin/src/rules/prefer-enum-initializers.ts 100.00% <0.00%> (ø)
packages/type-utils/src/getDeclaration.ts 0.00% <0.00%> (ø)
packages/utils/src/eslint-utils/deepMerge.ts 89.47% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-loop-func.ts 98.11% <0.00%> (ø)
...ckages/eslint-plugin/src/rules/no-magic-numbers.ts 80.64% <0.00%> (ø)
... and 220 more

@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label May 15, 2022
@bradzacher
Copy link
Member

bradzacher commented May 15, 2022 •
edited
Loading

we can add some config to enable the signal for the PR title
https://github.com/zeke/semantic-pull-requests#configuration
File: .github/semantic.yml

enabled: true
titleOnly: true
scopes:
  - ast-utils
  - ...
types:
  - feat
  - fix
  - docs
  - chore
  - test
  - revert

I've double checked and we have the app installed in the repo so it should just work?

@bradzacher
Copy link
Member

alternately we could setup our own action instead of using the app
https://github.com/amannn/action-semantic-pull-request

@bradzacher bradzacher mentioned this pull request May 16, 2022
Closed
@armano2

This comment was marked as resolved.

Sign in to view
@bradzacher bradzacher mentioned this pull request May 30, 2022
Closed
@bradzacher
Copy link
Member

bradzacher commented May 30, 2022 •
edited
Loading

Spun off the action discussion as a new issue #5110

@bradzacher bradzacher merged commit 90f3960 into typescript-eslint:main May 30, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the remove-commitlint branch December 24, 2022 08:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armano2 armano2 armano2 approved these changes

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo maintenance: remove commitlint
3 participants
@JoshuaKGoldberg @bradzacher @armano2