Skip to content

chore: allow publishing canary versions #5015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2022
Merged

chore: allow publishing canary versions #5015

merged 1 commit into from
May 18, 2022

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented May 18, 2022 •
edited
Loading

Overview

Correct issue with credentials not being setup in publish_canary_version action after changes to #4959

Please note that you need to set the registry-url to https://registry.npmjs.org/ in setup-node to properly configure your credentials.

https://github.com/actions/setup-node/blob/bacd6b4b3ac3127b28a1e1920c23bf1c2cadbb85/src/main.ts#L42-L46

    const registryUrl: string = core.getInput('registry-url');
    const alwaysAuth: string = core.getInput('always-auth');
    if (registryUrl) {
      auth.configAuthentication(registryUrl, alwaysAuth);
    }

https://docs.github.com/en/actions/publishing-packages/publishing-nodejs-packages#publishing-packages-to-the-npm-registry

@nx-cloud
Copy link

nx-cloud bot commented May 18, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0e7513d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented May 18, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 0e7513d
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62856159719ffe00093655eb
😎 Deploy Preview https://deploy-preview-5015--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@armano2 armano2 changed the title chore: fix issue with publishing canary versions chore: allow publishing canary versions May 18, 2022
@armano2 armano2 requested a review from bradzacher May 18, 2022 21:14
bradzacher
bradzacher approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this!

@bradzacher bradzacher merged commit c673e15 into main May 18, 2022
@bradzacher bradzacher deleted the chore/correct-publish_canary_version-action branch May 18, 2022 21:28
@armano2 armano2 added the repo maintenance things to do with maintenance of the repo, and not with code/docs label May 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @bradzacher