Skip to content

feat(eslint-plugin): [space-infix-ops] missing error report for conditional types #5041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 26, 2022
Merged

feat(eslint-plugin): [space-infix-ops] missing error report for conditional types #5041

merged 4 commits into from
May 26, 2022

Conversation

holazz
Copy link
Contributor

@holazz holazz commented May 22, 2022

PR Checklist

Overview

@nx-cloud
Copy link

nx-cloud bot commented May 22, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2064bcd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @holazz!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented May 22, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 2064bcd
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/628f965bf035490008392a93
😎 Deploy Preview https://deploy-preview-5041--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bradzacher bradzacher added the bug Something isn't working label May 23, 2022
@bradzacher bradzacher changed the title fix(eslint-plugin): [space-infix-ops] missing error report for conditional types feat(eslint-plugin): [space-infix-ops] missing error report for conditional types May 23, 2022
bradzacher
bradzacher requested changes May 23, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

We've found reusing selectors like this is very brittle and can easily break!

Instead of hacking the AST to reuse their internal code - let's just fork their logic - it'll be less lines and it'll mean we are better able to modify it in future if we need.

@bradzacher bradzacher added awaiting response Issues waiting for a reply from the OP or another party enhancement New feature or request and removed bug Something isn't working labels May 23, 2022
@holazz
Copy link
Contributor Author

holazz commented May 23, 2022

Thanks for this!

We've found reusing selectors like this is very brittle and can easily break!

Instead of hacking the AST to reuse their internal code - let's just fork their logic - it'll be less lines and it'll mean we are better able to modify it in future if we need.

Sorry, I saw some such usage in the source code, I thought it was intentional. I have changed it, please review it.

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label May 23, 2022
@armano2 armano2 added the package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin label May 25, 2022
@holazz
Copy link
Contributor Author

holazz commented May 26, 2022

is there any status update on this? 🤔

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just hoping for some more tests. 🙂

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label May 26, 2022
@holazz
Copy link
Contributor Author

holazz commented May 26, 2022

@JoshuaKGoldberg I added some more test cases, please review!

JoshuaKGoldberg
JoshuaKGoldberg approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks great. Thanks for the fix!

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) May 26, 2022 15:01
@bradzacher bradzacher disabled auto-merge May 26, 2022 15:43
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label May 26, 2022
@bradzacher bradzacher merged commit 0bfab6c into typescript-eslint:main May 26, 2022
@holazz holazz deleted the fix/space-infix-ops branch May 26, 2022 23:17
@armano2 armano2 mentioned this pull request May 30, 2022
Merged
3 tasks
@hasban12138 hasban12138 mentioned this pull request May 31, 2022
Closed
4 tasks
This was referenced Jun 1, 2022
Merged
Merged
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Jun 5, 2022
Update typescript-eslint monorepo to v5.27.0 (#1385)
917449d 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.26.0` -> `5.27.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.26.0/5.27.0) |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.26.0` -> `5.27.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.26.0/5.27.0) |

---

### Release Notes

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>

### [`v5.27.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5270-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5260v5270-2022-05-30)

[Compare Source](typescript-eslint/typescript-eslint@v5.26.0...v5.27.0)

##### Bug Fixes

-   **eslint-plugin:** \[no-type-alias] handle Template Literal Types ([#&#8203;5092](typescript-eslint/typescript-eslint#5092)) ([8febf11](typescript-eslint/typescript-eslint@8febf11))

##### Features

-   \[4.7] support new extensions ([#&#8203;5027](typescript-eslint/typescript-eslint#5027)) ([efc147b](typescript-eslint/typescript-eslint@efc147b))
-   **eslint-plugin:** \[ban-ts-comment] add descriptionFormat option ([#&#8203;5026](typescript-eslint/typescript-eslint#5026)) ([1fb31a4](typescript-eslint/typescript-eslint@1fb31a4))
-   **eslint-plugin:** \[no-misused-promises] warn when spreading promises ([#&#8203;5053](typescript-eslint/typescript-eslint#5053)) ([61ffa9e](typescript-eslint/typescript-eslint@61ffa9e))
-   **eslint-plugin:** \[space-infix-ops] missing error report for conditional types ([#&#8203;5041](typescript-eslint/typescript-eslint#5041)) ([0bfab6c](typescript-eslint/typescript-eslint@0bfab6c))

</details>

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>

### [`v5.27.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5270-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5260v5270-2022-05-30)

[Compare Source](typescript-eslint/typescript-eslint@v5.26.0...v5.27.0)

##### Bug Fixes

-   **types:** remove leftovers from removal of useJSXTextNode ([#&#8203;5091](typescript-eslint/typescript-eslint#5091)) ([f9c3647](typescript-eslint/typescript-eslint@f9c3647))

##### Features

-   \[4.7] support new extensions ([#&#8203;5027](typescript-eslint/typescript-eslint#5027)) ([efc147b](typescript-eslint/typescript-eslint@efc147b))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1385
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@armano2 armano2 mentioned this pull request Jun 6, 2022
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher requested changes

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [space-infix-ops] Missing error report for conditional types
4 participants
@holazz @JoshuaKGoldberg @bradzacher @armano2