test: fix Cypress test flakes #5086
Conversation
|
Thanks for the PR, @Josh-Cena! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -31,7 +31,9 @@ runs: | |||
| - uses: actions/cache@v3 | |||
| id: yarn-cache | |||
| with: | |||
| path: ${{ steps.yarn-cache-dir-path.outputs.dir }} | |||
| path: | | |||
| ${{ steps.yarn-cache-dir-path.outputs.dir }} | |||
There was a problem hiding this comment.
This is essentially a subpath of ~/.cache. I don't know if there would be any adverse effects if we simply cache the entire ~/.cache, or if I should constrain it to certain subpaths.
|
I have to |
.github/workflows/ci.yml
Outdated
| - name: Cypress run | ||
| uses: cypress-io/github-action@v2 | ||
| with: | ||
| project: ./packages/website | ||
| start: yarn start | ||
| wait-on: http://localhost:3000 |
There was a problem hiding this comment.
Side fix: this should be able to fix the ESOCKETTIMEDOUT error.
|
@JoshuaKGoldberg Do you want to try bumping the Cypress version in this PR? Doesn't seem that flaky now. |
😨 |
|
maybe we don't need the |
|
Right... I'm still worried that ESOCKETTIMEDOUT will come back, particularly if we stop pinning our Cypress version. |
|
yolo |
PR Checklist
Overview