chore(website): [playground] support enum values and remove compilerOptions filter #5125
Conversation
…filter compilerOptions
|
Thanks for the PR, @armano2! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -13,6 +13,13 @@ export function createCompilerOptions( | |||
| module: window.ts.ModuleKind.ESNext as number, | |||
| ...tsConfig, | |||
| jsx: jsx ? window.ts.JsxEmit.Preserve : window.ts.JsxEmit.None, | |||
| moduleResolution: undefined, | |||
| lib: undefined, | |||
There was a problem hiding this comment.
this line can be removed after #5162 is merged
|
feel free to merge once you've resolved the conflict @armano2 |
…itor-to-not-remove-options
|
@bradzacher done |
|
Oh sorry I forgot you don't have admin rights to merge without a review. |
PR Checklist
Overview
further refine and improve visual config editor, this should correct potential issues with providing configs like in #5121
compilerOptions will no longer be filtered out from not supported values in visualEditor and enum values will be displayed correctly as dropdown fields
additionally fields,
moduleResolution, lib, plugins, typeRoots, paths, moduleDetection, baseUrlwill be ignoredrelated to changes done in #5112