Skip to content

chore(website): [playground] create new model with jsx support if needed #5128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2022
Merged

chore(website): [playground] create new model with jsx support if needed #5128

merged 1 commit into from
Jun 1, 2022

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented May 31, 2022 •
edited
Loading

PR Checklist

Overview

This change fixes issues witch switching from and to jsx

with code:

function x() {
  return <div></div>
}

before this change if you try to switch to jsx, playground is going to report bunch of issues

Playground #5128 Playground main

@nx-cloud
Copy link

nx-cloud bot commented May 31, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ebcd3ad. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented May 31, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ebcd3ad
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/629685d71dab960008d7fb3e
😎 Deploy Preview https://deploy-preview-5128--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented May 31, 2022 •
edited
Loading

Codecov Report

Merging #5128 (ebcd3ad) into main (c9c0569) will decrease coverage by 0.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5128      +/-   ##
==========================================
- Coverage   91.70%   91.32%   -0.39%     
==========================================
  Files         362      132     -230     
  Lines       12181     1487   -10694     
  Branches     3530      224    -3306     
==========================================
- Hits        11171     1358    -9813     
+ Misses        661       65     -596     
+ Partials      349       64     -285
Flag Coverage Δ
unittest 91.32% <ø> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../utils/src/ast-utils/eslint-utils/scopeAnalysis.ts
packages/utils/src/ts-eslint/Linter.ts
packages/eslint-plugin/src/util/escapeRegExp.ts
packages/utils/src/eslint-utils/nullThrows.ts
packages/eslint-plugin/src/rules/semi.ts
...kages/eslint-plugin/src/rules/init-declarations.ts
packages/type-utils/src/getContextualType.ts
...n/src/rules/no-non-null-asserted-optional-chain.ts
...-estree/src/create-program/createProjectProgram.ts
...ges/type-utils/src/getConstrainedTypeAtLocation.ts
... and 220 more

@armano2 armano2 changed the title chore(website): create new model with jsx support if needed chore(website): [playground] create new model with jsx support if needed May 31, 2022
bradzacher
bradzacher approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

olddudenoice

@bradzacher bradzacher merged commit a7fddd0 into main Jun 1, 2022
@bradzacher bradzacher deleted the fix/website-improve-support-for-jsx branch June 1, 2022 00:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Website Playground
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @bradzacher