Skip to content

chore(website): [playground] correct scope analysis class names #5140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2022
Merged

chore(website): [playground] correct scope analysis class names #5140

merged 1 commit into from
Jun 4, 2022

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Jun 4, 2022 •
edited
Loading

PR Checklist

Overview

Do not mangle class names in playground

this is fixing regression from adding source maps to ease debugging

image

@nx-cloud
Copy link

nx-cloud bot commented Jun 4, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0ed6275. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Jun 4, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 0ed6275
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/629b86355f41ce00087fcc63
😎 Deploy Preview https://deploy-preview-5140--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@armano2 armano2 changed the title fix(website): [playground] correct scope analysis class names chore(website): [playground] correct scope analysis class names Jun 4, 2022
@codecov
Copy link

codecov bot commented Jun 4, 2022 •
edited
Loading

Codecov Report

Merging #5140 (0ed6275) into main (ce3083e) will increase coverage by 2.50%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5140      +/-   ##
==========================================
+ Coverage   91.32%   93.83%   +2.50%     
==========================================
  Files         132      286     +154     
  Lines        1487     9839    +8352     
  Branches      224     2939    +2715     
==========================================
+ Hits         1358     9232    +7874     
- Misses         65      328     +263     
- Partials       64      279     +215
Flag Coverage Δ
unittest 93.83% <ø> (+2.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/eslint-plugin/src/rules/no-restricted-imports.ts 96.42% <0.00%> (ø)
...n/src/rules/no-non-null-asserted-optional-chain.ts 46.66% <0.00%> (ø)
...eslint-plugin/src/rules/no-useless-empty-export.ts 100.00% <0.00%> (ø)
...lugin/src/rules/consistent-indexed-object-style.ts 92.06% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/prefer-readonly.ts 99.08% <0.00%> (ø)
...slint-plugin/src/rules/prefer-enum-initializers.ts 100.00% <0.00%> (ø)
...slint-plugin/src/rules/prefer-namespace-keyword.ts 100.00% <0.00%> (ø)
...-plugin/src/rules/naming-convention-utils/enums.ts 100.00% <0.00%> (ø)
...-plugin/src/rules/restrict-template-expressions.ts 100.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-type-alias.ts 100.00% <0.00%> (ø)
... and 144 more

@bradzacher bradzacher added the package: website Issues related to the @typescript-eslint website label Jun 4, 2022
@bradzacher bradzacher merged commit 8dc1f92 into main Jun 4, 2022
@bradzacher bradzacher deleted the fix/scope-anaylisys-class-names branch June 4, 2022 16:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
package: website Issues related to the @typescript-eslint website website: playground
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @bradzacher