Skip to content

docs: remove unexpected 'as const' in incorrect example #5161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2022

Conversation

mutoe
Copy link
Contributor

@mutoe mutoe commented Jun 8, 2022

PR Checklist

Overview

https://deploy-preview-5161--typescript-eslint.netlify.app/rules/explicit-module-boundary-types#allowdirectconstassertioninarrowfunctions

@nx-cloud
Copy link

nx-cloud bot commented Jun 8, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 12419e3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @mutoe!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Jun 8, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 12419e3
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62a297fb8a2d620009e06560
😎 Deploy Preview https://deploy-preview-5161--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@armano2 armano2 added the documentation Documentation ("docs") that needs adding/updating label Jun 9, 2022
armano2
armano2 previously approved these changes Jun 9, 2022
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #5161 (1f02cfe) into main (921cdf1) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 1f02cfe differs from pull request most recent head 12419e3. Consider uploading reports for the commit 12419e3 to get more accurate results

@@            Coverage Diff             @@
##             main    #5161      +/-   ##
==========================================
- Coverage   93.82%   93.82%   -0.01%     
==========================================
  Files         287      286       -1     
  Lines        9861     9828      -33     
  Branches     2950     2939      -11     
==========================================
- Hits         9252     9221      -31     
+ Misses        329      328       -1     
+ Partials      280      279       -1     
Flag Coverage Δ
unittest 93.82% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lugin/src/rules/consistent-generic-constructors.ts

@bradzacher bradzacher enabled auto-merge (squash) June 10, 2022 01:02
@bradzacher bradzacher merged commit 4a34f1b into typescript-eslint:main Jun 10, 2022
@mutoe mutoe deleted the patch-2 branch June 11, 2022 14:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants