Skip to content

chore(website): [playground] correct issues with libs #5162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 13, 2022
Merged

chore(website): [playground] correct issues with libs #5162

merged 12 commits into from
Jun 13, 2022

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Jun 8, 2022 •
edited
Loading

PR Checklist

Overview

Correct issue with loading libs between editor and code, "lib" resolution imitates to behavior

Changes

  • editor and linting is using now exact copy of typescript definitions.
    there is no additional calls to cdn to retrieve type definitions, unless sandbox is not exposing types (old ts versions)

  • lib, options can be provided in tsconfig and its going to be properly used

  • parsing and validation of tsconfig is done by typescript utils

  • ctrl+click on types defined in libs is now working correctly

    lib: es6
    image
    lib: esnext
    image

Test cases

@armano2 armano2 added bug Something isn't working package: website Issues related to the @typescript-eslint website labels Jun 8, 2022
@nx-cloud
Copy link

nx-cloud bot commented Jun 8, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 036f13c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Jun 8, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 036f13c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62a51e5e216f6d0009a77a23
😎 Deploy Preview https://deploy-preview-5162--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@armano2 armano2 changed the title chore(website): [playground] correct issues with changing default lib chore(website): [playground] correct issues with libs Jun 8, 2022
@armano2 armano2 mentioned this pull request Jun 9, 2022
Merged
3 tasks
@armano2 armano2 requested a review from JoshuaKGoldberg June 9, 2022 01:31
@armano2
Copy link
Collaborator Author

armano2 commented Jun 10, 2022 •
edited
Loading

@bradzacher suggested change applied

@codecov
Copy link

codecov bot commented Jun 10, 2022 •
edited
Loading

Codecov Report

Merging #5162 (036f13c) into main (dc1f930) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5162      +/-   ##
==========================================
- Coverage   91.55%   91.33%   -0.23%     
==========================================
  Files         344      132     -212     
  Lines       10801     1488    -9313     
  Branches     3164      224    -2940     
==========================================
- Hits         9889     1359    -8530     
+ Misses        589       65     -524     
+ Partials      323       64     -259
Flag Coverage Δ
unittest 91.33% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/typedef.ts
...rc/rules/indent-new-do-not-use/BinarySearchTree.ts
...plugin/src/rules/no-unnecessary-type-constraint.ts
...plugin-internal/src/rules/prefer-ast-types-enum.ts
...lugin/src/rules/prefer-readonly-parameter-types.ts
...nt-plugin/src/rules/indent-new-do-not-use/index.ts
...nt-plugin/src/rules/lines-between-class-members.ts
...internal/src/rules/no-typescript-default-import.ts
.../eslint-plugin/src/rules/prefer-ts-expect-error.ts
...slint-plugin/src/rules/no-unnecessary-qualifier.ts
... and 202 more

@armano2 armano2 removed the request for review from JoshuaKGoldberg June 10, 2022 22:41
@armano2 armano2 enabled auto-merge (squash) June 11, 2022 22:59
bradzacher
bradzacher approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks-good-to-me

@bradzacher bradzacher disabled auto-merge June 13, 2022 01:03
@bradzacher bradzacher merged commit 6b17ad0 into main Jun 13, 2022
@bradzacher bradzacher deleted the fix/default-lib-import-5142 branch June 13, 2022 01:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working package: website Issues related to the @typescript-eslint website website: playground
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Playground not emitting some type-aware lint errors
2 participants
@armano2 @bradzacher