Skip to content

docs(website): [playground] add links to documentation and improve fixers #5169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 12, 2022
Merged

docs(website): [playground] add links to documentation and improve fixers #5169

merged 3 commits into from
Jun 12, 2022

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Jun 10, 2022 •
edited
Loading

PR Checklist

Overview

Playground

  • default fixer is no longer displaying redundant line and its positioned on same line as error,
  • new details has been added that points to rule documentation provided by rule
    image
  • rule name is correctly highlighted in tooltip and points to rule documentation
    image

@armano2 armano2 added the package: website Issues related to the @typescript-eslint website label Jun 10, 2022
@nx-cloud
Copy link

nx-cloud bot commented Jun 10, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b820abe. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Jun 10, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit b820abe
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62a500a8cd3d7300080a5626
😎 Deploy Preview https://deploy-preview-5169--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jun 10, 2022 •
edited
Loading

Codecov Report

Merging #5169 (b820abe) into main (dc1f930) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5169      +/-   ##
==========================================
- Coverage   91.55%   91.33%   -0.23%     
==========================================
  Files         344      132     -212     
  Lines       10801     1488    -9313     
  Branches     3164      224    -2940     
==========================================
- Hits         9889     1359    -8530     
+ Misses        589       65     -524     
+ Partials      323       64     -259
Flag Coverage Δ
unittest 91.33% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/eslint-plugin/src/rules/no-misused-promises.ts
packages/type-utils/src/getDeclaration.ts
...ages/eslint-plugin/src/rules/default-param-last.ts
...t-plugin/src/rules/class-literal-property-style.ts
...kages/eslint-plugin/src/rules/naming-convention.ts
.../eslint-plugin/src/rules/prefer-ts-expect-error.ts
...s/utils/src/ast-utils/eslint-utils/astUtilities.ts
...slint-plugin/src/rules/no-unnecessary-qualifier.ts
...ackages/eslint-plugin/src/rules/no-for-in-array.ts
packages/eslint-plugin-tslint/src/custom-linter.ts
... and 202 more

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Jun 11, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic 👏 Thanks!!

@armano2 armano2 requested a review from JoshuaKGoldberg June 11, 2022 23:00
@armano2 armano2 merged commit 78af93b into main Jun 12, 2022
@armano2 armano2 deleted the fix/improve-fix-presentation-and-add-missing-links branch June 12, 2022 07:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Josh-Cena Josh-Cena Josh-Cena left review comments

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
package: website Issues related to the @typescript-eslint website website: playground
Projects
None yet
Milestone
No milestone
3 participants
@armano2 @JoshuaKGoldberg @Josh-Cena