Skip to content

docs(website): [playground] show tooltips bellow hovered code #5198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Jun 16, 2022

PR Checklist

Overview

Correct displaying tooltip errors in first line
related facebook/docusaurus#7592

@armano2 armano2 added package: website Issues related to the @typescript-eslint website website: playground labels Jun 16, 2022
@nx-cloud
Copy link

nx-cloud bot commented Jun 16, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4284062. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Jun 16, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4284062
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62b474c08ef7b70008b49000
😎 Deploy Preview https://deploy-preview-5198--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #5198 (f20883c) into main (33fdaa6) will decrease coverage by 0.37%.
The diff coverage is n/a.

❗ Current head f20883c differs from pull request most recent head 4284062. Consider uploading reports for the commit 4284062 to get more accurate results

@@            Coverage Diff             @@
##             main    #5198      +/-   ##
==========================================
- Coverage   91.70%   91.33%   -0.38%     
==========================================
  Files         363      132     -231     
  Lines       12205     1488   -10717     
  Branches     3541      224    -3317     
==========================================
- Hits        11193     1359    -9834     
+ Misses        662       65     -597     
+ Partials      350       64     -286     
Flag Coverage Δ
unittest 91.33% <ø> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/eslint-plugin/src/rules/no-unused-expressions.ts
...ackages/eslint-plugin/src/rules/no-explicit-any.ts
...ges/utils/src/ast-utils/eslint-utils/predicates.ts
packages/eslint-plugin-tslint/src/rules/config.ts
packages/utils/src/ts-eslint/index.ts
packages/utils/src/eslint-utils/index.ts
packages/eslint-plugin/src/util/misc.ts
packages/eslint-plugin/src/configs/base.ts
...ges/type-utils/src/getConstrainedTypeAtLocation.ts
...plugin/src/rules/no-unnecessary-type-constraint.ts
... and 221 more

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) June 23, 2022 14:12
@JoshuaKGoldberg JoshuaKGoldberg merged commit 0957f93 into main Jun 23, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the fix/playground-show-tooltips-bellow branch June 23, 2022 14:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: website Issues related to the @typescript-eslint website website: playground
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants