Skip to content

chore: removed pre-push hook #5235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2022
Merged

chore: removed pre-push hook #5235

merged 1 commit into from
Jun 23, 2022

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Per the issue, commits still run Prettier on staged->committed files. We just no longer also run Prettier on all files when pushing.

@nx-cloud
Copy link

nx-cloud bot commented Jun 23, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5d22ab6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Jun 23, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 5d22ab6
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62b48b4d38ec920008b70a07
😎 Deploy Preview https://deploy-preview-5235--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review June 23, 2022 16:05
@codecov
Copy link

codecov bot commented Jun 23, 2022 •
edited
Loading

Codecov Report

Merging #5235 (5d22ab6) into main (0957f93) will increase coverage by 0.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5235      +/-   ##
==========================================
+ Coverage   91.33%   91.70%   +0.37%     
==========================================
  Files         132      363     +231     
  Lines        1488    12205   +10717     
  Branches      224     3541    +3317     
==========================================
+ Hits         1359    11193    +9834     
- Misses         65      662     +597     
- Partials       64      350     +286
Flag Coverage Δ
unittest 91.70% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/type-utils/src/getTokenAtPosition.ts 0.00% <0.00%> (ø)
...pt-estree/src/create-program/createWatchProgram.ts 78.06% <0.00%> (ø)
packages/eslint-plugin/src/configs/all.ts 100.00% <0.00%> (ø)
...ges/eslint-plugin/src/rules/space-before-blocks.ts 100.00% <0.00%> (ø)
...eslint-plugin/src/rules/no-parameter-properties.ts 94.11% <0.00%> (ø)
...lugin/src/rules/consistent-indexed-object-style.ts 92.06% <0.00%> (ø)
packages/typescript-estree/src/simple-traverse.ts 75.00% <0.00%> (ø)
.../eslint-plugin/src/rules/no-useless-constructor.ts 95.23% <0.00%> (ø)
...nt-plugin/src/rules/lines-between-class-members.ts 92.85% <0.00%> (ø)
packages/typescript-estree/src/ast-converter.ts 100.00% <0.00%> (ø)
... and 221 more

@bradzacher bradzacher merged commit 2de7223 into typescript-eslint:main Jun 23, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the remove-pre-push-hook branch June 23, 2022 23:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Git hooks should run Prettier only on changed files in commits
2 participants
@JoshuaKGoldberg @bradzacher