chore(website): make docusaurus show twitter card image #5253
Conversation
|
Thanks for the PR, @connorlurring! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Super, thanks for this @connorlurring! 🚀
Although view-source:https://deploy-preview-5253--typescript-eslint.netlify.app/ points to the now-404ing https://typescript-eslint.io/img/logo-twitter-card.png for the image, https://deploy-preview-5253--typescript-eslint.netlify.app/img/logo-twitter-card.png does indeed work. So this should be fine when it hits main.
|
That's correct Josh, docusaurus uses the base URL set in the config to create the path to the meta image URLs. When writing it I replaced the base URL with the one to my ngrok tunnel and all worked as expected on the Twitter card tester. |
PR Checklist
Overview
Twitter Card docs reference
logo-twitter-card.png) with a 2:1 aspect ratio as per the Twitter Card docs.