Skip to content

feat(utils): remove (ts-)eslint-scope types #5256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 26, 2022
Merged

feat(utils): remove (ts-)eslint-scope types #5256

merged 4 commits into from
Oct 26, 2022

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jun 26, 2022 •
edited by bradzacher
Loading

BREAKING CHANGE:
removes types from the utils package API

PR Checklist

Overview

Per the issue, directly deletes the types.

Is chore(utils)!: ... the right PR title format...?

@nx-cloud
Copy link

nx-cloud bot commented Jun 26, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bf185b2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Jun 26, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 5f9ded7
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62b8cf63742b6100093170b7
😎 Deploy Preview https://deploy-preview-5256--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review June 26, 2022 21:34
@codecov
Copy link

codecov bot commented Jun 26, 2022 •
edited
Loading

Codecov Report

Merging #5256 (5f9ded7) into v6 (cf2956f) will increase coverage by 0.21%.
The diff coverage is n/a.

❗ Current head 5f9ded7 differs from pull request most recent head bf185b2. Consider uploading reports for the commit bf185b2 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##               v6    #5256      +/-   ##
==========================================
+ Coverage   91.33%   91.54%   +0.21%     
==========================================
  Files         364      335      -29     
  Lines       12114    10751    -1363     
  Branches     3530     3166     -364     
==========================================
- Hits        11064     9842    -1222     
+ Misses        751      594     -157     
- Partials      299      315      +16
Flag Coverage Δ
unittest 91.54% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/scope-manager/src/scope/index.ts 5.26% <0.00%> (-94.74%) ⬇️
packages/scope-manager/src/definition/index.ts 7.69% <0.00%> (-92.31%) ⬇️
packages/utils/src/ts-eslint/index.ts 11.11% <0.00%> (-88.89%) ⬇️
packages/utils/src/eslint-utils/index.ts 12.50% <0.00%> (-87.50%) ⬇️
packages/utils/src/ast-utils/eslint-utils/index.ts 20.00% <0.00%> (-80.00%) ⬇️
packages/utils/src/ast-utils/index.ts 25.00% <0.00%> (-75.00%) ⬇️
packages/scope-manager/src/index.ts 45.45% <0.00%> (-27.28%) ⬇️
...s/scope-manager/src/scope/ClassStaticBlockScope.ts 75.00% <0.00%> (-25.00%) ⬇️
packages/utils/src/eslint-utils/deepMerge.ts 89.47% <0.00%> (-10.53%) ⬇️
packages/eslint-plugin/src/util/astUtils.ts 83.33% <0.00%> (-5.56%) ⬇️
... and 254 more

@bradzacher bradzacher changed the title chore(utils)!: remove (ts-)eslint-scope types feat(utils): remove (ts-)eslint-scope types Jul 2, 2022
@bradzacher bradzacher added the breaking change This change will require a new major version to be released label Jul 2, 2022
@bradzacher bradzacher added this to the 6.0.0 milestone Jul 2, 2022
@bradzacher bradzacher changed the base branch from main to v6 October 26, 2022 08:17
bradzacher
bradzacher approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Don't forget to remove the dependency from the package!

typescript-eslint/packages/utils/package.json

Line 47 in 2ee81df

"eslint-scope": "^5.1.1",

@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 26, 2022
@JoshuaKGoldberg JoshuaKGoldberg merged commit fff0e29 into typescript-eslint:v6 Oct 26, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the remove-ts-eslint-scope-types branch October 26, 2022 14:43
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Nov 12, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge breaking change This change will require a new major version to be released
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

Remove eslint-scope types from utils
2 participants
@JoshuaKGoldberg @bradzacher