Skip to content

fix(scope-manager): allow visiting of constraint in infer type #5331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 18, 2022
Merged

fix(scope-manager): allow visiting of constraint in infer type #5331

merged 3 commits into from
Jul 18, 2022

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Jul 10, 2022

PR Checklist

Overview

Add visiting of constraint in infer type

@nx-cloud
Copy link

nx-cloud bot commented Jul 10, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8dd1bb0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Jul 10, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 8dd1bb0
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62d2e46d1bf34700085ae9af
😎 Deploy Preview https://deploy-preview-5331--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@armano2 armano2 added the package: scope-manager Issues related to @typescript-eslint/scope-manager label Jul 10, 2022
armano2
armano2 commented Jul 10, 2022
View reviewed changes
packages/scope-manager/tests/fixtures/type-declaration/infer-type-constraint.ts.shot
Comment on lines +16 to +23
Reference$2 {
identifier: Identifier<"X">,
isRead: true,
isTypeReference: true,
isValueReference: false,
isWrite: false,
resolved: Variable$2,
},
Copy link
Collaborator Author

@armano2 armano2 Jul 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

X has now correct reference

@codecov
Copy link

codecov bot commented Jul 10, 2022 •
edited
Loading

Codecov Report

Merging #5331 (8dd1bb0) into main (4138b0d) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5331      +/-   ##
==========================================
- Coverage   91.67%   91.50%   -0.17%     
==========================================
  Files         363      344      -19     
  Lines       12227    10811    -1416     
  Branches     3549     3168     -381     
==========================================
- Hits        11209     9893    -1316     
+ Misses        668      595      -73     
+ Partials      350      323      -27
Flag Coverage Δ
unittest 91.50% <100.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/scope-manager/src/referencer/TypeVisitor.ts 97.95% <100.00%> (+0.02%) ⬆️
packages/visitor-keys/src/visitor-keys.ts
...ckages/typescript-estree/src/jsx/xhtml-entities.ts
...ript-estree/src/create-program/createSourceFile.ts
...ges/typescript-estree/src/create-program/shared.ts
packages/typescript-estree/src/convert.ts
packages/typescript-estree/src/ast-converter.ts
packages/typescript-estree/src/ts-estree/index.ts
...escript-estree/src/semantic-or-syntactic-errors.ts
...pt-estree/src/create-program/createWatchProgram.ts
... and 10 more

@armano2 armano2 requested a review from bradzacher July 11, 2022 23:09
@bradzacher bradzacher added the bug Something isn't working label Jul 18, 2022
@bradzacher bradzacher merged commit b2846a1 into main Jul 18, 2022
@bradzacher bradzacher deleted the fix/scope-manager-visiting-infer-contraint branch July 18, 2022 16:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working package: scope-manager Issues related to @typescript-eslint/scope-manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-unused-vars] Does not recognize usage in TS 4.7 "infer + extends" syntax
2 participants
@armano2 @bradzacher