Skip to content

chore(website): add current version of typescript to playground dropdown #5341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Jul 12, 2022

PR Checklist

Overview

lock typescript version dropdown while playground is loading and add currently loaded ts version to dropdown

@armano2 armano2 added bug Something isn't working website: playground labels Jul 12, 2022
@nx-cloud
Copy link

nx-cloud bot commented Jul 12, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 26a9ea4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Jul 12, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 26a9ea4
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62d2e46a4cad2c000957251a
😎 Deploy Preview https://deploy-preview-5341--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@armano2 armano2 changed the title chore(website): add current version of typescript to dropdown chore(website): add current version of typescript to playground dropdown Jul 12, 2022
@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #5341 (26a9ea4) into main (4138b0d) will decrease coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5341      +/-   ##
==========================================
- Coverage   91.67%   91.34%   -0.33%     
==========================================
  Files         363      132     -231     
  Lines       12227     1491   -10736     
  Branches     3549      226    -3323     
==========================================
- Hits        11209     1362    -9847     
+ Misses        668       65     -603     
+ Partials      350       64     -286     
Flag Coverage Δ
unittest 91.34% <ø> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/no-redeclare.ts
packages/eslint-plugin/src/rules/indent.ts
packages/utils/src/ts-eslint/RuleTester.ts
.../eslint-plugin/src/rules/restrict-plus-operands.ts
.../eslint-plugin/src/rules/no-useless-constructor.ts
...eslint-plugin/src/rules/no-useless-empty-export.ts
...escript-estree/src/create-program/getScriptKind.ts
...ges/eslint-plugin/src/rules/space-before-blocks.ts
...es/eslint-plugin/src/util/getOperatorPrecedence.ts
...-plugin/src/rules/explicit-member-accessibility.ts
... and 221 more

@armano2 armano2 added the package: website Issues related to the @typescript-eslint website label Jul 20, 2022
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@bradzacher bradzacher merged commit a0d5a70 into main Jul 22, 2022
@bradzacher bradzacher deleted the fix/website-add-current-ts-version-to-options-5244 branch July 22, 2022 18:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working package: website Issues related to the @typescript-eslint website website: playground
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: wrong typescript version displayed in the playground
3 participants