chore: tighter linting #535
Conversation
|
Hey @JamesHenry, I'll OFC need to update this to the latest master, as it's rather out of date, but could you have a look over the eslint config specifically, as I recall you saying you didn't like some things in it. I'd like to get some stricter linting in to help catch some some hard-to-notice problems in PRs (such as rules in |
|
I'm afraid I don't remember 😅 Overall looks fine, just the couple of instances of the same question above. Also, I wonder if we should require an explanation comment each time there is an I think there are already rules/plugins out there that offer that feature... |
# Conflicts: # packages/eslint-plugin/src/rules/prefer-regexp-exec.ts # packages/experimental-utils/package.json # packages/parser/package.json # packages/parser/typings/eslint.d.ts # packages/typescript-estree/package.json # yarn.lock
Unless I'm blind - a quick google doesn't return any results for this. |
# Conflicts: # package.json # packages/eslint-plugin-tslint/package.json # packages/eslint-plugin/package.json # packages/eslint-plugin/src/rules/no-object-literal-type-assertion.ts # packages/eslint-plugin/tests/eslint-rules/no-redeclare.test.ts # packages/eslint-plugin/tests/rules/array-type.test.ts # packages/experimental-utils/src/eslint-utils/batchedSingleLineTests.ts # packages/parser/package.json # packages/typescript-estree/package.json # yarn.lock
|
fyi - i raised mysticatea/eslint-plugin-eslint-comments#29 I might see if I can implement that when I have time. |
Sorry for jumping the gun!