Skip to content

chore(website): add formatting (Prettier) page #5363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Adds a strongly-worded page explaining to people that they shouldn't use a linter as a formatter. 💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Jul 22, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit af17ab2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Jul 22, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit af17ab2
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62daf1876ea56c0008cf611f
😎 Deploy Preview https://deploy-preview-5363--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #5363 (af17ab2) into main (7ea14ae) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5363      +/-   ##
==========================================
+ Coverage   91.35%   91.36%   +0.01%     
==========================================
  Files         132      132              
  Lines        1492     1494       +2     
  Branches      226      226              
==========================================
+ Hits         1363     1365       +2     
  Misses         65       65              
  Partials       64       64              
Flag Coverage Δ
unittest 91.36% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/scope-manager/src/referencer/Referencer.ts 95.96% <0.00%> (+0.03%) ⬆️

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@bradzacher bradzacher merged commit 2588e9e into typescript-eslint:main Jul 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Add our opinion on delegating stylistic issues to a tool such as Prettier
2 participants