Skip to content

chore(eslint-plugin): stop linting rule output formatting in tests #5379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 17, 2022
Merged

chore(eslint-plugin): stop linting rule output formatting in tests #5379

merged 6 commits into from
Aug 17, 2022

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Inside the @typescript-eslint/internal/plugin-test-formatting rule, no longer checks formatting for output properties.

Removes noFormat, .trim(), .trimEnd(), and .trimRight() from test outputs.

@nx-cloud
Copy link

nx-cloud bot commented Jul 25, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0aa93de. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Jul 25, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 0aa93de
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62fcd7d774d1e30008cfb9da
😎 Deploy Preview https://deploy-preview-5379--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: stop linting rule output formatting in tests chore(eslint-plugin): stop linting rule output formatting in tests Jul 25, 2022
@codecov
Copy link

codecov bot commented Jul 25, 2022 •
edited
Loading

Codecov Report

Merging #5379 (a9db51d) into main (68e288f) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

❗ Current head a9db51d differs from pull request most recent head 0aa93de. Consider uploading reports for the commit 0aa93de to get more accurate results

@@            Coverage Diff             @@
##             main    #5379      +/-   ##
==========================================
- Coverage   93.86%   93.62%   -0.24%     
==========================================
  Files         290      295       +5     
  Lines        9991    10200     +209     
  Branches     3008     3065      +57     
==========================================
+ Hits         9378     9550     +172     
- Misses        332      361      +29     
- Partials      281      289       +8
Flag Coverage Δ
unittest 93.62% <100.00%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lugin-internal/src/rules/plugin-test-formatting.ts 79.85% <100.00%> (ø)
...s/scope-manager/src/scope/ClassStaticBlockScope.ts 75.00% <0.00%> (-25.00%) ⬇️
packages/scope-manager/src/ScopeManager.ts 77.21% <0.00%> (-2.54%) ⬇️
...ackages/eslint-plugin/src/rules/no-extra-parens.ts 90.41% <0.00%> (-0.38%) ⬇️
.../eslint-plugin/src/rules/no-useless-constructor.ts 95.23% <0.00%> (-0.22%) ⬇️
...kages/scope-manager/src/referencer/ClassVisitor.ts 94.01% <0.00%> (-0.11%) ⬇️
packages/eslint-plugin/src/rules/no-unsafe-call.ts 100.00% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/no-explicit-any.ts 92.85% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/prefer-as-const.ts 100.00% <0.00%> (ø)
...kages/eslint-plugin/src/rules/naming-convention.ts 81.09% <0.00%> (ø)
... and 19 more

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review July 25, 2022 23:46
bradzacher
bradzacher previously approved these changes Aug 7, 2022
View reviewed changes
@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Aug 7, 2022
@bradzacher
Copy link
Member

image

@bradzacher bradzacher enabled auto-merge (squash) August 17, 2022 12:06
@bradzacher bradzacher merged commit a28e0ef into typescript-eslint:main Aug 17, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the plugin-test-formatting-ignore-output branch August 17, 2022 14:40
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Aug 18, 2022
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@typescript-eslint/internal/plugin-test-formatting too strict about snapshot indentation
2 participants
@JoshuaKGoldberg @bradzacher