Skip to content

fix(eslint-plugin): remove valid-typeof disable in eslint-recommended #5381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2022
Merged

fix(eslint-plugin): remove valid-typeof disable in eslint-recommended #5381

merged 2 commits into from
Oct 26, 2022

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jul 25, 2022 •
edited by bradzacher
Loading

BREAKING CHANGE:
Removes the 'valid-typeof': 'off' line from eslint-recommended.ts, as it's not always covered by TypeScript.

PR Checklist

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Jul 25, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ffb7f09. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 24 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Jul 25, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ffb7f09
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/635838212f3409000842f463
😎 Deploy Preview https://deploy-preview-5381--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin breaking change This change will require a new major version to be released labels Jul 25, 2022
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review July 25, 2022 23:22
@JoshuaKGoldberg JoshuaKGoldberg changed the title fix(eslint-plugin): remove valid-typeof disable in eslint-recommended fix!(eslint-plugin): remove valid-typeof disable in eslint-recommended Jul 25, 2022
@bradzacher bradzacher changed the title fix!(eslint-plugin): remove valid-typeof disable in eslint-recommended fix(eslint-plugin): remove valid-typeof disable in eslint-recommended Aug 6, 2022
@bradzacher bradzacher added this to the 6.0.0 milestone Aug 6, 2022
@JoshuaKGoldberg JoshuaKGoldberg changed the base branch from main to v6 October 25, 2022 21:16
bradzacher
bradzacher approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 26, 2022
@JoshuaKGoldberg
Copy link
Member Author

Website CI tests failed to download from azure.archive.ubuntu.com. New flake I've never seen before.

Get:138 http://azure.archive.ubuntu.com/ubuntu focal-updates/main amd64 libopengl0 amd64 1.3.2-1~ubuntu0.20.04.2 [29.2 kB]
Fetched 71.3 MB in 14min 51s (80.0 kB/s)
E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/universe/g/gupnp-igd/libgupnp-igd-1.0-4_0.2.5-5_amd64.deb  Connection failed [IP: 52.252.75.106 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
Failed to install browsers
Error: Installation process exited with code: 100

@JoshuaKGoldberg JoshuaKGoldberg merged commit b90e7c3 into typescript-eslint:v6 Oct 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge breaking change This change will require a new major version to be released package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

[valid-typeof] @typescript-eslint/recommended disables valid-typeof but it shouldn't
2 participants
@JoshuaKGoldberg @bradzacher