fix(eslint-plugin): [no-useless-constructor] handle parameter decorator #5450

yeonjuan · 2022-08-09T16:10:13Z

PR Checklist

Addresses an existing open issue: fixes Bug: no-useless-constructor rule doesn't work properly with NestJS DI #5201
That issue was marked as accepting prs
Steps in CONTRIBUTING.md were taken

Overview

nx-cloud · 2022-08-09T16:10:15Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2e7813f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

typescript-eslint · 2022-08-09T16:10:17Z

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

netlify · 2022-08-09T16:10:18Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`2e7813f`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/62fbebc7e26b3f000981eb55
😎 Deploy Preview	https://deploy-preview-5450--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov · 2022-08-09T16:25:32Z

Codecov Report

Merging #5450 (b012da0) into main (f92e66a) will increase coverage by 2.46%.
The diff coverage is 100.00%.

❗ Current head b012da0 differs from pull request most recent head 2e7813f. Consider uploading reports for the commit 2e7813f to get more accurate results

@@            Coverage Diff             @@
##             main    #5450      +/-   ##
==========================================
+ Coverage   91.36%   93.83%   +2.46%     
==========================================
  Files         132      290     +158     
  Lines        1494     9989    +8495     
  Branches      226     3008    +2782     
==========================================
+ Hits         1365     9373    +8008     
- Misses         65      335     +270     
- Partials       64      281     +217

Flag	Coverage Δ
unittest	`93.83% <100.00%> (+2.46%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../eslint-plugin/src/rules/no-useless-constructor.ts	`95.45% <100.00%> (ø)`
packages/eslint-plugin/src/rules/await-thenable.ts	`100.00% <0.00%> (ø)`
...int-plugin/src/rules/strict-boolean-expressions.ts	`98.81% <0.00%> (ø)`
...s/eslint-plugin/src/rules/no-non-null-assertion.ts	`87.09% <0.00%> (ø)`
packages/eslint-plugin/src/rules/indent.ts	`92.85% <0.00%> (ø)`
...es/eslint-plugin/src/rules/no-invalid-void-type.ts	`95.12% <0.00%> (ø)`
...-plugin/src/rules/explicit-function-return-type.ts	`100.00% <0.00%> (ø)`
...ackages/eslint-plugin/src/rules/space-infix-ops.ts	`100.00% <0.00%> (ø)`
...ges/eslint-plugin/src/rules/no-inferrable-types.ts	`95.00% <0.00%> (ø)`
... and 149 more

JoshuaKGoldberg

Excellent, thanks! 🔥

packages/eslint-plugin/src/rules/no-useless-constructor.ts

JoshuaKGoldberg · 2022-08-09T17:09:26Z

packages/eslint-plugin/src/rules/no-useless-constructor.ts

-      param => param.type === AST_NODE_TYPES.TSParameterProperty,
+      param =>
+        param.type === AST_NODE_TYPES.TSParameterProperty ||
+        param.decorators?.length,


Aside: it might be the case that param.decorators would make sense as a check, as it might be that the parser doesn't create param.decorators if it would have length 0. But that's a nuance not yet strongly defined in AST parsing. #5020

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.33.1` -> `5.35.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.33.1/5.35.1) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.33.1` -> `5.35.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.33.1/5.35.1) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v5.35.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5351-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5350v5351-2022-08-24) [Compare Source](typescript-eslint/typescript-eslint@v5.35.0...v5.35.1) ##### Bug Fixes - **eslint-plugin:** correct rule schemas to pass ajv validation ([#5531](typescript-eslint/typescript-eslint#5531)) ([dbf8b56](typescript-eslint/typescript-eslint@dbf8b56)) ### [`v5.35.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5350-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5340v5350-2022-08-24) [Compare Source](typescript-eslint/typescript-eslint@v5.34.0...v5.35.0) ##### Features - **eslint-plugin:** \[explicit-member-accessibility] suggest adding explicit accessibility specifiers ([#5492](typescript-eslint/typescript-eslint#5492)) ([0edb94a](typescript-eslint/typescript-eslint@0edb94a)) ### [`v5.34.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5340-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5331v5340-2022-08-22) [Compare Source](typescript-eslint/typescript-eslint@v5.33.1...v5.34.0) ##### Bug Fixes - **eslint-plugin:** \[no-useless-constructor] handle parameter decorator ([#5450](typescript-eslint/typescript-eslint#5450)) ([864dbcf](typescript-eslint/typescript-eslint@864dbcf)) ##### Features - **eslint-plugin:** \[prefer-optional-chain] support suggesting `!foo || !foo.bar` as a valid match for the rule ([#5266](typescript-eslint/typescript-eslint#5266)) ([aca935c](typescript-eslint/typescript-eslint@aca935c)) #### [5.33.1](typescript-eslint/typescript-eslint@v5.33.0...v5.33.1) (2022-08-15) ##### Bug Fixes - missing placeholders in violation messages for `no-unnecessary-type-constraint` and `no-unsafe-argument` (and enable `eslint-plugin/recommended` rules internally) ([#5453](typescript-eslint/typescript-eslint#5453)) ([d023910](typescript-eslint/typescript-eslint@d023910)) </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v5.35.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5351-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5350v5351-2022-08-24) [Compare Source](typescript-eslint/typescript-eslint@v5.35.0...v5.35.1) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) ### [`v5.35.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5350-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5340v5350-2022-08-24) [Compare Source](typescript-eslint/typescript-eslint@v5.34.0...v5.35.0) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) ### [`v5.34.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5340-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5331v5340-2022-08-22) [Compare Source](typescript-eslint/typescript-eslint@v5.33.1...v5.34.0) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) #### [5.33.1](typescript-eslint/typescript-eslint@v5.33.0...v5.33.1) (2022-08-15) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [x] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Co-authored-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1519 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

fix(eslint-plugin): [no-useless-constructor] handle parameter decorator

3442fc5

yeonjuan force-pushed the fix/#5201 branch from bb66a05 to 3442fc5 Compare August 9, 2022 16:10

JoshuaKGoldberg previously approved these changes Aug 9, 2022

View reviewed changes

packages/eslint-plugin/src/rules/no-useless-constructor.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg reviewed Aug 9, 2022

View reviewed changes

JoshuaKGoldberg dismissed their stale review via 78c7b1e August 9, 2022 17:09

Update packages/eslint-plugin/src/rules/no-useless-constructor.ts

78c7b1e

JoshuaKGoldberg enabled auto-merge (squash) August 9, 2022 17:09

yeonjuan and others added 2 commits August 15, 2022 17:07

Merge branch 'main' into fix/typescript-eslint#5201

b012da0

Merge branch 'main' into fix/typescript-eslint#5201

2e7813f

JoshuaKGoldberg approved these changes Aug 16, 2022

View reviewed changes

JoshuaKGoldberg merged commit 864dbcf into typescript-eslint:main Aug 16, 2022

github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(eslint-plugin): [no-useless-constructor] handle parameter decorator #5450

fix(eslint-plugin): [no-useless-constructor] handle parameter decorator #5450

yeonjuan commented Aug 9, 2022

nx-cloud bot commented Aug 9, 2022 •

edited

Loading

typescript-eslint bot commented Aug 9, 2022

netlify bot commented Aug 9, 2022 •

edited

Loading

codecov bot commented Aug 9, 2022 •

edited

Loading

JoshuaKGoldberg left a comment

JoshuaKGoldberg Aug 9, 2022

fix(eslint-plugin): [no-useless-constructor] handle parameter decorator #5450

fix(eslint-plugin): [no-useless-constructor] handle parameter decorator #5450

Conversation

yeonjuan commented Aug 9, 2022

PR Checklist

Overview

nx-cloud bot commented Aug 9, 2022 • edited Loading

☁️ Nx Cloud Report

typescript-eslint bot commented Aug 9, 2022

netlify bot commented Aug 9, 2022 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

codecov bot commented Aug 9, 2022 • edited Loading

Codecov Report

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg Aug 9, 2022

Choose a reason for hiding this comment

nx-cloud bot commented Aug 9, 2022 •

edited

Loading

netlify bot commented Aug 9, 2022 •

edited

Loading

codecov bot commented Aug 9, 2022 •

edited

Loading