Skip to content

docs: no-duplicate-enum-values missing comma #5466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2022
Merged

docs: no-duplicate-enum-values missing comma #5466

merged 1 commit into from
Aug 12, 2022

Conversation

christophehurpeau
Copy link
Contributor

PR Checklist

Overview

Fix syntax error on second enum example

@nx-cloud
Copy link

nx-cloud bot commented Aug 12, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4b3d48b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @christophehurpeau!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Aug 12, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4b3d48b
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62f60fc78dbcb4000902cf82
😎 Deploy Preview https://deploy-preview-5466--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Aug 12, 2022 •
edited
Loading

Codecov Report

Merging #5466 (4b3d48b) into main (8762dfd) will increase coverage by 2.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5466      +/-   ##
==========================================
+ Coverage   91.36%   93.83%   +2.46%     
==========================================
  Files         132      290     +158     
  Lines        1494     9988    +8494     
  Branches      226     3006    +2780     
==========================================
+ Hits         1365     9372    +8007     
- Misses         65      335     +270     
- Partials       64      281     +217
Flag Coverage Δ
unittest 93.83% <ø> (+2.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...slint-plugin/src/rules/prefer-namespace-keyword.ts 100.00% <0.00%> (ø)
...eslint-plugin/src/rules/type-annotation-spacing.ts 81.94% <0.00%> (ø)
...eslint-plugin/src/rules/no-unsafe-member-access.ts 100.00% <0.00%> (ø)
...s/eslint-plugin/src/rules/no-non-null-assertion.ts 87.09% <0.00%> (ø)
...s/eslint-plugin/src/rules/no-restricted-imports.ts 96.42% <0.00%> (ø)
...ges/eslint-plugin/src/rules/no-misused-promises.ts 98.35% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-loop-func.ts 98.11% <0.00%> (ø)
...src/rules/naming-convention-utils/parse-options.ts 100.00% <0.00%> (ø)
...s/eslint-plugin/src/rules/no-dupe-class-members.ts 87.50% <0.00%> (ø)
...lugin/src/rules/padding-line-between-statements.ts 93.83% <0.00%> (ø)
... and 148 more

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot, thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit dc54196 into typescript-eslint:main Aug 12, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophehurpeau @JoshuaKGoldberg