feat(eslint-plugin): [no-explicit-any] ignoreRestArgs #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #548 +/- ##
==========================================
+ Coverage 94.19% 94.26% +0.06%
==========================================
Files 105 104 -1
Lines 4323 4252 -71
Branches 1185 1160 -25
==========================================
- Hits 4072 4008 -64
+ Misses 146 142 -4
+ Partials 105 102 -3
|
bradzacher
requested changes
May 22, 2019
There was a problem hiding this comment.
Thanks for your contribution!
A few things for you:
- you need to add support for more cases of function definitions:
function foo1(...args: any[]) {}
const bar1 = function (...args: any[]) {}
const baz1 = (...args: any[]) => {}
// readonly array[]:
function foo2(...args: readonly any[]) {}
const bar2 = function (...args: readonly any[]) {}
const baz2 = (...args: readonly any[]) => {}
// generics
function foo3(...args: Array<any>) {}
const bar3 = function (...args: Array<any>) {}
const baz3 = (...args: Array<any>) => {}
function foo4(...args: ReadonlyArray<any>) {}
const bar4 = function (...args: ReadonlyArray<any>) {}
const baz4 = (...args: ReadonlyArray<any>) => {}should these be valid as well? Technically they're valid typescript, but they make less sense semantically. Probably good to guard against them.
function foo5(...args: any) {}
const bar5 = function (...args: any) {}
const baz5 = (...args: any) => {}- Please add examples to the docs to help explain the option's function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #397