Skip to content

chore: test node v14 on ci.yml #5512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2022
Merged

chore: test node v14 on ci.yml #5512

merged 1 commit into from
Aug 21, 2022

Conversation

m4thieulavoie
Copy link
Contributor

PR Checklist

Overview

Since node 12 isn't supported anymore, this PR changes the oldest node version to 14. The CI will now run tests on node 14 and 18

@nx-cloud
Copy link

nx-cloud bot commented Aug 19, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3e4dbf0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @m4thieulavoie!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@m4thieulavoie m4thieulavoie mentioned this pull request Aug 19, 2022
Closed
@netlify
Copy link

netlify bot commented Aug 19, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 3e4dbf0
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62fee3c3a09afe000818149a
😎 Deploy Preview https://deploy-preview-5512--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Aug 19, 2022 •
edited
Loading

Codecov Report

Merging #5512 (3e4dbf0) into main (c950051) will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5512      +/-   ##
==========================================
+ Coverage   91.57%   91.70%   +0.12%     
==========================================
  Files         132      366     +234     
  Lines        1496    12345   +10849     
  Branches      226     3603    +3377     
==========================================
+ Hits         1370    11321    +9951     
- Misses         62      671     +609     
- Partials       64      353     +289
Flag Coverage Δ
unittest 91.70% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/no-type-alias.ts 100.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/comma-dangle.ts 93.33% <0.00%> (ø)
...es/eslint-plugin/src/rules/object-curly-spacing.ts 100.00% <0.00%> (ø)
...es/eslint-plugin/src/rules/prefer-function-type.ts 97.18% <0.00%> (ø)
packages/eslint-plugin/src/rules/typedef.ts 96.00% <0.00%> (ø)
...-estree/src/create-program/createProjectProgram.ts 94.28% <0.00%> (ø)
...plugin/src/rules/naming-convention-utils/shared.ts 100.00% <0.00%> (ø)
...es/eslint-plugin/src/util/getOperatorPrecedence.ts 42.85% <0.00%> (ø)
...-plugin/src/rules/no-unnecessary-type-arguments.ts 98.14% <0.00%> (ø)
...escript-estree/src/semantic-or-syntactic-errors.ts 86.66% <0.00%> (ø)
... and 224 more

@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Aug 21, 2022
bradzacher
bradzacher approved these changes Aug 21, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brilliant - thanks for this!

image

@bradzacher bradzacher merged commit fde1c63 into typescript-eslint:main Aug 21, 2022
@m4thieulavoie m4thieulavoie deleted the node14_ci_yml branch August 22, 2022 11:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Stop testing on Node 12
2 participants
@m4thieulavoie @bradzacher