Skip to content

chore(eslint-plugin): use defs, not definitions, in rule schemas #5534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 24, 2022
Merged

chore(eslint-plugin): use defs, not definitions, in rule schemas #5534

merged 2 commits into from
Aug 24, 2022

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 23, 2022 •
edited
Loading

PR Checklist

Overview

Does a find-and-replace per the issue: definitions -> $defs.

@nx-cloud
Copy link

nx-cloud bot commented Aug 23, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 230f212. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Aug 23, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 230f212
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/630620021309270009c7f9e0
😎 Deploy Preview https://deploy-preview-5534--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Aug 23, 2022 •
edited
Loading

Codecov Report

Merging #5534 (082e18f) into main (6ab767b) will increase coverage by 2.34%.
The diff coverage is n/a.

❗ Current head 082e18f differs from pull request most recent head 230f212. Consider uploading reports for the commit 230f212 to get more accurate results

@@            Coverage Diff             @@
##             main    #5534      +/-   ##
==========================================
+ Coverage   91.57%   93.92%   +2.34%     
==========================================
  Files         132      290     +158     
  Lines        1496    10017    +8521     
  Branches      226     3016    +2790     
==========================================
+ Hits         1370     9408    +8038     
- Misses         62      330     +268     
- Partials       64      279     +215
Flag Coverage Δ
unittest 93.92% <ø> (+2.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/array-type.ts 97.14% <ø> (ø)
packages/eslint-plugin/src/rules/ban-ts-comment.ts 96.96% <ø> (ø)
packages/eslint-plugin/src/rules/comma-dangle.ts 93.33% <ø> (ø)
...-plugin/src/rules/explicit-member-accessibility.ts 97.18% <ø> (ø)
...lugin/src/rules/padding-line-between-statements.ts 93.83% <ø> (ø)
...es/eslint-plugin/src/rules/parameter-properties.ts 94.11% <ø> (ø)
...nt-plugin/src/rules/space-before-function-paren.ts 100.00% <0.00%> (ø)
...es/eslint-plugin/src/rules/no-array-constructor.ts 100.00% <0.00%> (ø)
...t-plugin/src/rules/adjacent-overload-signatures.ts 95.34% <0.00%> (ø)
...int-plugin/src/rules/consistent-type-assertions.ts 88.88% <0.00%> (ø)
... and 154 more

@JoshuaKGoldberg JoshuaKGoldberg changed the title chore(eslint-plugin): use , not definitions, in rule schemas chore(eslint-plugin): use defs, not definitions, in rule schemas Aug 23, 2022
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review August 23, 2022 20:16
@bradzacher
Copy link
Member

Double checking that if you rebase the other or on top of this yhrn all the tests pass.

If yes then let's gooo
this_is_stampa.gif

@bradzacher
Copy link
Member

Also idk if the deploy preview is wrong but it seems like the union didn't extract still?

Screenshot_20220824-174552.png

@JoshuaKGoldberg
Copy link
Member Author

That's on production too 😞.

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) August 24, 2022 12:59
@JoshuaKGoldberg JoshuaKGoldberg merged commit 4a805d5 into typescript-eslint:main Aug 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Migrate json-schema from deprecated $definitions to $defs
2 participants
@JoshuaKGoldberg @bradzacher