Skip to content

feat(eslint-plugin): added new rule prefer-readonly #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 24, 2019
Merged

feat(eslint-plugin): added new rule prefer-readonly #555

merged 10 commits into from
Jun 24, 2019

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented May 26, 2019 •
edited
Loading

Adds the equivalent of TSLint's prefer-readonly rule.

Edit: will fix up post merge soon...! ✔️

@codecov
Copy link

codecov bot commented May 28, 2019 •
edited
Loading

Codecov Report

Merging #555 into master will increase coverage by 0.07%.
The diff coverage is 97.43%.

@@            Coverage Diff            @@
##           master    #555      +/-   ##
=========================================
+ Coverage   94.22%   94.3%   +0.07%     
=========================================
  Files         108     109       +1     
  Lines        4419    4533     +114     
  Branches     1217    1253      +36     
=========================================
+ Hits         4164    4275     +111     
- Misses        147     148       +1     
- Partials      108     110       +2
Impacted Files Coverage Δ
...n/src/rules/indent-new-do-not-use/OffsetStorage.ts 100% <ø> (ø) ⬆️
...lugin/src/rules/indent-new-do-not-use/TokenInfo.ts 100% <ø> (ø) ⬆️
packages/typescript-estree/src/convert.ts 98.96% <100%> (ø) ⬆️
packages/eslint-plugin/src/rules/index.ts 100% <100%> (ø) ⬆️
packages/eslint-plugin-tslint/src/custom-linter.ts 100% <100%> (ø) ⬆️
packages/eslint-plugin/src/util/types.ts 82.05% <83.33%> (+0.23%) ⬆️
...ackages/eslint-plugin/src/rules/prefer-readonly.ts 99% <99%> (ø)

@bradzacher bradzacher added the enhancement: new plugin rule New rule request for eslint-plugin label May 28, 2019
bradzacher
bradzacher requested changes Jun 1, 2019
View reviewed changes
@bradzacher
Copy link
Member

great work!
code itself LGTM.
few nits

@JamesHenry JamesHenry requested a review from bradzacher June 23, 2019 23:08
@JamesHenry JamesHenry added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 23, 2019
@bradzacher bradzacher merged commit 76b89a5 into typescript-eslint:master Jun 24, 2019
@JoshuaKGoldberg JoshuaKGoldberg deleted the prefer-readonly branch June 24, 2019 16:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge enhancement: new plugin rule New rule request for eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshuaKGoldberg @bradzacher @JamesHenry