Skip to content

test: add fixtures for exported classes with decorators #5558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2022
Merged

test: add fixtures for exported classes with decorators #5558

merged 1 commit into from
Aug 29, 2022

Conversation

bradzacher
Copy link
Member

PR Checklist

Overview

Just adding these ahead of #5551 so that it's easy to verify that we aren't introducing a regression with the parser upgrade

@bradzacher bradzacher added the tests anything to do with testing label Aug 29, 2022
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Aug 29, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0da3e5d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Aug 29, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 0da3e5d
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/630c26dd5c634e00093b0366
😎 Deploy Preview https://deploy-preview-5558--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Aug 29, 2022 •
edited
Loading

Codecov Report

Merging #5558 (0da3e5d) into main (39829c0) will increase coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5558      +/-   ##
==========================================
+ Coverage   91.57%   91.74%   +0.17%     
==========================================
  Files         132      364     +232     
  Lines        1496    12373   +10877     
  Branches      226     3611    +3385     
==========================================
+ Hits         1370    11352    +9982     
- Misses         62      669     +607     
- Partials       64      352     +288
Flag Coverage Δ
unittest 91.74% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/no-for-in-array.ts 100.00% <0.00%> (ø)
...plugin/src/rules/no-unnecessary-type-constraint.ts 88.00% <0.00%> (ø)
packages/typescript-estree/src/convert-comments.ts 100.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-shadow.ts 75.84% <0.00%> (ø)
...es/eslint-plugin/src/rules/no-unsafe-assignment.ts 94.21% <0.00%> (ø)
...int-plugin/src/rules/require-array-sort-compare.ts 88.23% <0.00%> (ø)
...es/eslint-plugin/src/util/isUndefinedIdentifier.ts 100.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-misused-new.ts 100.00% <0.00%> (ø)
packages/utils/src/eslint-utils/index.ts 12.50% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/no-implied-eval.ts 97.05% <0.00%> (ø)
... and 222 more

@bradzacher bradzacher merged commit 14b33a4 into main Aug 29, 2022
@bradzacher bradzacher deleted the exported-decorator-fixtures-pre-4.8 branch August 29, 2022 02:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
tests anything to do with testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bradzacher