chore(website): fix playground #5575
Conversation
|
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5575 +/- ##
==========================================
+ Coverage 91.60% 91.62% +0.02%
==========================================
Files 369 134 -235
Lines 12393 1505 -10888
Branches 3613 226 -3387
==========================================
- Hits 11352 1379 -9973
+ Misses 685 62 -623
+ Partials 356 64 -292
Flags with carried forward coverage won't be shown. Click here to find out more. |
b1cd0b7 to
8026e77
Compare
PR Checklist
Overview
There's a lot of unrelated changes in here - it took me a while to really nail down exactly what the problem was. I spent a chunk of time just figuring out how everything worked.
I still don't know why it occurred, but for some reason when we upgraded to TS4.8 the website-eslint build started including a dependency that required
osandstream(nodejs modules). Because rollup can't bundle nodejs modules - it assumed they'd be provided later, which they weren't - leading to unresolved imports that (I think) monaco attempted to resolve by loading a script from the server.Result of testing with this PR locally:
