Skip to content

docs(eslint-plugin): fix no-throw-literal options type #5591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2022
Merged

docs(eslint-plugin): fix no-throw-literal options type #5591

merged 2 commits into from
Sep 4, 2022

Conversation

haines
Copy link
Contributor

@haines haines commented Sep 2, 2022

#5386 changed the docs for the no-throw-literal options to show them extending from the no-shadow options. In fact, the base no-throw-literal rule does not have any options, so this PR removes the references to the base options.

@nx-cloud
Copy link

nx-cloud bot commented Sep 2, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 61cadfd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @haines!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Sep 2, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 61cadfd
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/631405a58b27440008b4defd
😎 Deploy Preview https://deploy-preview-5591--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@haines haines changed the title docs(eslint-plugin): Fix no-throw-literal options type docs(eslint-plugin): fix no-throw-literal options type Sep 2, 2022
@codecov
Copy link

codecov bot commented Sep 2, 2022 •
edited
Loading

Codecov Report

Merging #5591 (42923f7) into main (4cbdc30) will increase coverage by 2.17%.
The diff coverage is n/a.

❗ Current head 42923f7 differs from pull request most recent head 61cadfd. Consider uploading reports for the commit 61cadfd to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5591      +/-   ##
==========================================
+ Coverage   91.63%   93.80%   +2.17%     
==========================================
  Files         134      292     +158     
  Lines        1506    10006    +8500     
  Branches      226     3008    +2782     
==========================================
+ Hits         1380     9386    +8006     
- Misses         62      338     +276     
- Partials       64      282     +218
Flag Coverage Δ
unittest 93.80% <ø> (+2.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../eslint-plugin/src/rules/member-delimiter-style.ts 94.73% <0.00%> (ø)
...t-plugin/src/rules/no-meaningless-void-operator.ts 100.00% <0.00%> (ø)
...kages/eslint-plugin/src/rules/init-declarations.ts 100.00% <0.00%> (ø)
...ckages/eslint-plugin/src/util/getThisExpression.ts 84.61% <0.00%> (ø)
...es/eslint-plugin/src/rules/prefer-function-type.ts 97.18% <0.00%> (ø)
...plugin/src/rules/naming-convention-utils/shared.ts 100.00% <0.00%> (ø)
...es/eslint-plugin/src/rules/no-duplicate-imports.ts 97.67% <0.00%> (ø)
...plugin/src/rules/naming-convention-utils/schema.ts 100.00% <0.00%> (ø)
...plugin/src/rules/prefer-string-starts-ends-with.ts 97.83% <0.00%> (ø)
...ges/eslint-plugin/src/rules/no-extraneous-class.ts 100.00% <0.00%> (ø)
... and 148 more

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 4, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot, thanks!

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) September 4, 2022 01:55
@JoshuaKGoldberg JoshuaKGoldberg merged commit 6634e86 into typescript-eslint:main Sep 4, 2022
@haines haines deleted the patch-1 branch September 4, 2022 08:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haines @JoshuaKGoldberg