Skip to content

test(eslint-plugin): [promise-function-async] Add regression tests for invalid async modifiers #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2019
Merged

test(eslint-plugin): [promise-function-async] Add regression tests for invalid async modifiers #560

merged 1 commit into from
May 28, 2019

Conversation

madbence
Copy link
Contributor

@madbence madbence commented May 27, 2019 •
edited
Loading

It seems like the rule is already smart enough to not check special methods (get, set, and constructor kinds), so i just added regression tests for them. As these kinds of methods cannot be marked async, the rule shouldn't check them in the first place.

refs #553

@madbence madbence force-pushed the add-invalid-ts-cases branch from a67c694 to 52b4696 Compare May 27, 2019 09:55
@madbence madbence changed the title [promise-function-async] Add regression tests for invalid async modifiers test(eslint-plugin): [promise-function-async] Add regression tests for invalid async modifiers May 27, 2019
@bradzacher bradzacher merged commit bba42eb into typescript-eslint:master May 28, 2019
@madbence madbence deleted the add-invalid-ts-cases branch May 28, 2019 19:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madbence @bradzacher