Skip to content

chore(website): uncollapse Rules sidebar by default again #5616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2022
Merged

chore(website): uncollapse Rules sidebar by default again #5616

merged 2 commits into from
Sep 19, 2022

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Sep 8, 2022 •
edited
Loading

PR Checklist

Overview

I'd missed (forgotten) in #5608 that createCategory is also used for rules pages (https://typescript-eslint.io/rules & its children). We want them to be fully expanded too.

FYI @santoshyadavdev - my bad 😄

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Sep 8, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 71c9a3d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Sep 8, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 71c9a3d
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6327ba9f5e7c220008a26a6c
😎 Deploy Preview https://deploy-preview-5616--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review September 8, 2022 01:48
@santoshyadavdev
Copy link
Contributor

cool 😊

bradzacher
bradzacher approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@bradzacher bradzacher changed the title fix(website): uncollapse Rules sidebar by default again chore(website): uncollapse Rules sidebar by default again Sep 19, 2022
@bradzacher bradzacher added the package: website Issues related to the @typescript-eslint website label Sep 19, 2022
@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) September 19, 2022 00:41
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #5616 (4de978d) into main (75d78a4) will increase coverage by 0.62%.
The diff coverage is n/a.

❗ Current head 4de978d differs from pull request most recent head 71c9a3d. Consider uploading reports for the commit 71c9a3d to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5616      +/-   ##
==========================================
+ Coverage   91.01%   91.63%   +0.62%     
==========================================
  Files         365      134     -231     
  Lines       11962     1506   -10456     
  Branches     3483      226    -3257     
==========================================
- Hits        10887     1380    -9507     
+ Misses        781       62     -719     
+ Partials      294       64     -230
Flag Coverage Δ
unittest 91.63% <ø> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/scope-manager/src/scope/index.ts 5.26% <0.00%> (-94.74%) ⬇️
packages/scope-manager/src/definition/index.ts 7.69% <0.00%> (-92.31%) ⬇️
packages/scope-manager/src/index.ts 45.45% <0.00%> (-27.28%) ⬇️
packages/scope-manager/src/analyze.ts 65.38% <0.00%> (ø)
packages/scope-manager/src/ScopeManager.ts 79.74% <0.00%> (ø)
packages/scope-manager/src/scope/ForScope.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/scope/ScopeBase.ts 91.46% <0.00%> (ø)
packages/scope-manager/src/scope/TypeScope.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/scope/WithScope.ts 81.81% <0.00%> (ø)
packages/scope-manager/src/scope/BlockScope.ts 100.00% <0.00%> (ø)
... and 268 more

@JoshuaKGoldberg JoshuaKGoldberg merged commit ef7a68c into typescript-eslint:main Sep 19, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the open-rules-menu branch September 19, 2022 00:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
package: website Issues related to the @typescript-eslint website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Website: Consider always expanding collapsible sidebar menus under docs/
3 participants
@JoshuaKGoldberg @santoshyadavdev @bradzacher