Skip to content

fix(website): Use extended base rule name from file's meta #5621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2022
Merged

fix(website): Use extended base rule name from file's meta #5621

merged 1 commit into from
Sep 11, 2022

Conversation

yokkkoso
Copy link
Contributor

PR Checklist

Overview

The name of the rules from typescript-eslint and eslint may differ (for example return-await rule in typescript-eslint and no-return-await rule in eslint) and the information specified in How to Use and some links on the page become broken and lead to the 404 page of the eslint site.

@nx-cloud
Copy link

nx-cloud bot commented Sep 11, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 64e52f4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @yokkkoso!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Sep 11, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 64e52f4
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/631d453f64dd3f00099c96aa
😎 Deploy Preview https://deploy-preview-5621--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Sep 11, 2022 •
edited
Loading

Codecov Report

Merging #5621 (64e52f4) into main (77d76e2) will decrease coverage by 2.17%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5621      +/-   ##
==========================================
- Coverage   93.80%   91.63%   -2.18%     
==========================================
  Files         292      134     -158     
  Lines       10009     1506    -8503     
  Branches     3010      226    -2784     
==========================================
- Hits         9389     1380    -8009     
+ Misses        338       62     -276     
+ Partials      282       64     -218
Flag Coverage Δ
unittest 91.63% <ø> (-2.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nt-plugin/src/rules/switch-exhaustiveness-check.ts
...ages/eslint-plugin/src/rules/no-unsafe-argument.ts
...kages/eslint-plugin/src/rules/naming-convention.ts
...ackages/eslint-plugin/src/rules/no-implied-eval.ts
...t-plugin/src/rules/no-confusing-void-expression.ts
...t-plugin/src/rules/class-literal-property-style.ts
...es/eslint-plugin/src/util/getOperatorPrecedence.ts
...s/eslint-plugin/src/rules/no-restricted-imports.ts
...eslint-plugin/src/rules/no-parameter-properties.ts
...eslint-plugin/src/rules/prefer-return-this-type.ts
... and 148 more

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! Thank you for this!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 7fd2f89 into typescript-eslint:main Sep 11, 2022
@yokkkoso yokkkoso mentioned this pull request Sep 12, 2022
Merged
3 tasks
JoshuaKGoldberg pushed a commit that referenced this pull request Sep 13, 2022
@yokkkoso
chore(website): correct true extendsBaseRule values (#5632)
5487f9a 
* fix(website): Use extended base rule name from file's meta

* fix(website): Fix #5621 bug
This was referenced Sep 13, 2022
Closed
Closed
This was referenced Oct 1, 2022
Closed
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Oct 10, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yokkkoso @JoshuaKGoldberg