Skip to content

chore(website): correct true extendsBaseRule values #5632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 13, 2022
Merged

chore(website): correct true extendsBaseRule values #5632

merged 4 commits into from
Sep 13, 2022

Conversation

yokkkoso
Copy link
Contributor

@yokkkoso yokkkoso commented Sep 12, 2022 •
edited
Loading

PR Checklist

Overview

In #5621 I didn't notice that the value of extendsBaseRule could be boolean, so some rules on the site was changed to true.

@nx-cloud
Copy link

nx-cloud bot commented Sep 12, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b234b51. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @yokkkoso!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Sep 12, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit b234b51
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63206f737082f70009f6f8e0
😎 Deploy Preview https://deploy-preview-5632--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg changed the title fix(website): Fix #5621 bug chore(website): correct true extendsBaseRule values Sep 13, 2022
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL also, thanks!

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) September 13, 2022 11:54
@codecov
Copy link

codecov bot commented Sep 13, 2022 •
edited
Loading

Codecov Report

Merging #5632 (b234b51) into main (009d564) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5632      +/-   ##
==========================================
+ Coverage   91.60%   91.63%   +0.03%     
==========================================
  Files         369      134     -235     
  Lines       12394     1506   -10888     
  Branches     3614      226    -3388     
==========================================
- Hits        11353     1380    -9973     
+ Misses        685       62     -623     
+ Partials      356       64     -292
Flag Coverage Δ
unittest 91.63% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lugin-internal/src/rules/plugin-test-formatting.ts
...lint-plugin/src/rules/prefer-nullish-coalescing.ts
...lugin/src/rules/prefer-readonly-parameter-types.ts
...-plugin/src/rules/naming-convention-utils/index.ts
...lugin/src/rules/consistent-indexed-object-style.ts
...ages/eslint-plugin/src/rules/no-empty-interface.ts
...lugin/src/rules/consistent-generic-constructors.ts
...kages/eslint-plugin/src/rules/naming-convention.ts
...ages/eslint-plugin/src/rules/ban-tslint-comment.ts
packages/type-utils/src/getDeclaration.ts
... and 225 more

@JoshuaKGoldberg JoshuaKGoldberg merged commit 5487f9a into typescript-eslint:main Sep 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yokkkoso @JoshuaKGoldberg