feat(eslint-plugin): added new rule no-dynamic-delete #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 27, 2019 16:39
Adds the equivalent of TSLint's `no-dynamic-delete`.
Codecov Report
@@ Coverage Diff @@
## master #565 +/- ##
==========================================
+ Coverage 93.98% 94.01% +0.03%
==========================================
Files 121 122 +1
Lines 5217 5246 +29
Branches 1444 1453 +9
==========================================
+ Hits 4903 4932 +29
Misses 179 179
Partials 135 135
|
JamesHenry
previously requested changes
Jun 20, 2019
There was a problem hiding this comment.
Nice work @JoshuaKGoldberg.
Looking at the requirements for the implementation, I think this rule is entirely syntactic.
In such cases it is hugely more performant to not leverage parserServices.
Please can you refactor this to use the TSESTree AST instead of requiring TSNodes?
bradzacher
reviewed
Jul 15, 2019
bradzacher
approved these changes
Aug 9, 2019
bradzacher
requested changes
Aug 10, 2019
added 7 commits
October 2, 2019 22:12
…com/JoshuaKGoldberg/typescript-eslint into typescript-eslint-no-dynamic-delete
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the equivalent of TSLint's
no-dynamic-delete.