Skip to content

chore: bump @swc/core to 1.3.1 #5659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2022
Merged

chore: bump @swc/core to 1.3.1 #5659

merged 1 commit into from
Sep 15, 2022

Conversation

bradzacher
Copy link
Member

They fixed the regression they introduced which was preventing us from upgrading (swc-project/swc#4851), but it looks like a newer version changed how things worked, so we can no longer spy on an ES6 module's exports.

This PR just converts those spies to be fully mocked modules to work around this and allow us to upgrade

@bradzacher bradzacher added the dependencies Issue about dependencies of the package label Sep 15, 2022
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Sep 15, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 135662c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Sep 15, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 135662c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6322dc44f359c100085fe496
😎 Deploy Preview https://deploy-preview-5659--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Sep 15, 2022 •
edited
Loading

Codecov Report

Merging #5659 (135662c) into main (8b785b5) will decrease coverage by 0.62%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5659      +/-   ##
==========================================
- Coverage   91.63%   91.01%   -0.63%     
==========================================
  Files         134      365     +231     
  Lines        1506    11962   +10456     
  Branches      226     3483    +3257     
==========================================
+ Hits         1380    10887    +9507     
- Misses         62      781     +719     
- Partials       64      294     +230
Flag Coverage Δ
unittest 91.01% <ø> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/utils/src/ts-eslint-scope/Scope.ts 52.17% <0.00%> (ø)
...s/eslint-plugin/src/rules/no-implicit-any-catch.ts 84.61% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/no-invalid-this.ts 80.00% <0.00%> (ø)
...s/eslint-plugin/src/rules/no-non-null-assertion.ts 87.09% <0.00%> (ø)
packages/utils/src/ts-eslint-scope/Reference.ts 66.66% <0.00%> (ø)
packages/type-utils/src/containsAllTypesByName.ts 0.00% <0.00%> (ø)
.../eslint-plugin/src/rules/triple-slash-reference.ts 100.00% <0.00%> (ø)
...es/eslint-plugin/src/rules/no-floating-promises.ts 100.00% <0.00%> (ø)
packages/utils/src/ts-eslint/SourceCode.ts 50.00% <0.00%> (ø)
...slint-plugin/src/rules/no-unnecessary-qualifier.ts 100.00% <0.00%> (ø)
... and 224 more

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The yarn.lock additions pain me because there's nothing we can do yet... It this pr is good!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 7394796 into main Sep 15, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the swc-core-1.3.1 branch September 15, 2022 09:27
@bradzacher
Copy link
Member Author

@JoshuaKGoldberg - we could stub all of those packages out if they aren't actually used by doing something like

"resolutions": {
  "@swc/core-android-arm-eabi": "npm:dummypkg-a@1.0.0"
}

it would at least reduce our install size and the install speed (as long as the packages aren't actually used)

@bradzacher bradzacher mentioned this pull request Sep 15, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
dependencies Issue about dependencies of the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradzacher @JoshuaKGoldberg