Skip to content

chore(website): add missing defaultOptions to custom rule example #5668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

vkarpov15
Copy link
Contributor

PR Checklist

Overview

Quick suggestion. The sample in the "Type Checking" section almost works, just missing defaultOptions. Figured I'd throw this in here.

@nx-cloud
Copy link

nx-cloud bot commented Sep 18, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c46850a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @vkarpov15!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Sep 18, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit c46850a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63287ba96c544500097dce06
😎 Deploy Preview https://deploy-preview-5668--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This code snippet is out of date, I'll go ahead and send a followup PR to clean it up...

@JoshuaKGoldberg JoshuaKGoldberg changed the title add missing defaultOptions chore(website): add missing defaultOptions Sep 19, 2022
@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) September 19, 2022 14:24
@JoshuaKGoldberg JoshuaKGoldberg changed the title chore(website): add missing defaultOptions chore(website): add missing defaultOptions to custom rule example Sep 19, 2022
@JoshuaKGoldberg JoshuaKGoldberg merged commit 7888d33 into typescript-eslint:main Sep 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants