feat(eslint-plugin): allow using void as a default type for a generic argument if allowInGenericTypeArguments is specified #5671

kazizi55 · 2022-09-19T16:27:43Z

PR Checklist

Addresses an existing open issue: fixes Bug: [no-invalid-void-type] Does not allow using void as a default type for a generic argument #5644
That issue was marked as accepting prs
Steps in CONTRIBUTING.md were taken

Overview

allows using void as a default type for a generic argument if allowInGenericTypeArguments is specified

nx-cloud · 2022-09-19T16:27:45Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 508ab8f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

typescript-eslint · 2022-09-19T16:27:47Z

Thanks for the PR, @kazizi55!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

netlify · 2022-09-19T16:28:00Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`508ab8f`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63390e6b137f95000950c686
😎 Deploy Preview	https://deploy-preview-5671--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov · 2022-09-19T17:55:41Z

Codecov Report

Merging #5671 (508ab8f) into main (5adf7bd) will increase coverage by 2.93%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5671      +/-   ##
==========================================
+ Coverage   91.01%   93.94%   +2.93%     
==========================================
  Files         365      288      -77     
  Lines       11962     9582    -2380     
  Branches     3483     2884     -599     
==========================================
- Hits        10887     9002    -1885     
+ Misses        781      333     -448     
+ Partials      294      247      -47

Flag	Coverage Δ
unittest	`93.94% <100.00%> (+2.93%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...es/eslint-plugin/src/rules/no-invalid-void-type.ts	`95.83% <100.00%> (+0.71%)`	⬆️
packages/utils/src/ts-eslint-scope/Referencer.ts
packages/typescript-estree/src/convert.ts
packages/utils/src/eslint-utils/RuleCreator.ts
...plugin-internal/src/rules/prefer-ast-types-enum.ts
packages/typescript-estree/src/convert-comments.ts
packages/typescript-estree/src/ts-estree/index.ts
packages/type-utils/src/getTokenAtPosition.ts
packages/utils/src/ts-eslint-scope/ScopeManager.ts
packages/utils/src/eslint-utils/RuleTester.ts
... and 68 more

JoshuaKGoldberg

The code looks good at first glance, but there's an odd bug in the edge cases. I can take a closer look once that's fixed. Thanks!

packages/eslint-plugin/tests/rules/no-invalid-void-type.test.ts

Changes

JoshuaKGoldberg

Getting closer, thanks! The tests all look good but the source code confused me a bit. I think we can simplify it to be more clear.

packages/eslint-plugin/src/rules/no-invalid-void-type.ts

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>

JoshuaKGoldberg

Super, thanks for sending this in & iterating @kazizi55! 🙌

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.38.1` -> `5.39.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.38.1/5.39.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.38.1` -> `5.39.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.38.1/5.39.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v5.39.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5390-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5381v5390-2022-10-03) [Compare Source](typescript-eslint/typescript-eslint@v5.38.1...v5.39.0) ##### Features - **eslint-plugin:** allow using void as a default type for a generic argument if allowInGenericTypeArguments is specified ([#5671](typescript-eslint/typescript-eslint#5671)) ([bb46ef0](typescript-eslint/typescript-eslint@bb46ef0)) #### [5.38.1](typescript-eslint/typescript-eslint@v5.38.0...v5.38.1) (2022-09-26) **Note:** Version bump only for package [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v5.39.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5390-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5381v5390-2022-10-03) [Compare Source](typescript-eslint/typescript-eslint@v5.38.1...v5.39.0) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) #### [5.38.1](typescript-eslint/typescript-eslint@v5.38.0...v5.38.1) (2022-09-26) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1572 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

kazizi55 added 2 commits September 20, 2022 01:11

feat: allow using void as a default type for a generic argument

0a7ccac

test: allow using void as a default type for a generic argument

86b42da

Merge branch 'main' into allow-using-void-as-default-for-generic

f2a4732

kazizi55 marked this pull request as draft September 19, 2022 16:36

fix: build error

d889d9f

kazizi55 and others added 2 commits September 24, 2022 18:51

Merge branch 'main' into allow-using-void-as-default-for-generic

9b8ce1e

fix: replace any

d03c941

kazizi55 marked this pull request as ready for review September 24, 2022 10:48

JoshuaKGoldberg previously requested changes Sep 24, 2022

View reviewed changes

packages/eslint-plugin/tests/rules/no-invalid-void-type.test.ts Outdated Show resolved Hide resolved

kazizi55 and others added 3 commits September 27, 2022 22:41

test: remove duplicate error

5225063

fix: report invalidVoidNotReturnOrGeneric only one time

2ed96e1

Merge branch 'main' into allow-using-void-as-default-for-generic

f0b5e70

kazizi55 requested a review from JoshuaKGoldberg September 27, 2022 14:11

JoshuaKGoldberg requested changes Sep 27, 2022

View reviewed changes

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Sep 27, 2022

kazizi55 and others added 6 commits October 2, 2022 11:28

Update packages/eslint-plugin/src/rules/no-invalid-void-type.ts

be5c6f4

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>

Update packages/eslint-plugin/src/rules/no-invalid-void-type.ts

a142182

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>

fix: rename function name

e0b9b0a

refactor: delete isTSTypeParameter and inline

4b7ad41

Merge branch 'main' into allow-using-void-as-default-for-generic

cfab851

refactor: checkDefaultVoid

508ab8f

kazizi55 requested a review from JoshuaKGoldberg October 2, 2022 04:25

JoshuaKGoldberg approved these changes Oct 2, 2022

View reviewed changes

JoshuaKGoldberg merged commit bb46ef0 into typescript-eslint:main Oct 2, 2022

kazizi55 deleted the allow-using-void-as-default-for-generic branch October 2, 2022 08:41

sync-by-unito bot mentioned this pull request Oct 4, 2022

build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.36.1 to 5.39.0 numbersprotocol/capture-lite#2157

Closed

This was referenced Oct 10, 2022

build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.30.6 to 5.39.0 SmartTokenLabs/token-negotiator#419

Closed

build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.30.6 to 5.40.0 SmartTokenLabs/token-negotiator#424

Merged

sync-by-unito bot mentioned this pull request Oct 25, 2022

build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.36.1 to 5.41.0 numbersprotocol/capture-lite#2211

Closed

sync-by-unito bot mentioned this pull request Nov 1, 2022

build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.36.1 to 5.42.0 numbersprotocol/capture-lite#2265

Closed

github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eslint-plugin): allow using void as a default type for a generic argument if allowInGenericTypeArguments is specified #5671

feat(eslint-plugin): allow using void as a default type for a generic argument if allowInGenericTypeArguments is specified #5671

kazizi55 commented Sep 19, 2022

nx-cloud bot commented Sep 19, 2022 •

edited

Loading

typescript-eslint bot commented Sep 19, 2022

netlify bot commented Sep 19, 2022 •

edited

Loading

codecov bot commented Sep 19, 2022 •

edited

Loading

JoshuaKGoldberg left a comment

JoshuaKGoldberg left a comment

JoshuaKGoldberg left a comment

feat(eslint-plugin): allow using void as a default type for a generic argument if allowInGenericTypeArguments is specified #5671

feat(eslint-plugin): allow using void as a default type for a generic argument if allowInGenericTypeArguments is specified #5671

Conversation

kazizi55 commented Sep 19, 2022

PR Checklist

Overview

nx-cloud bot commented Sep 19, 2022 • edited Loading

☁️ Nx Cloud Report

typescript-eslint bot commented Sep 19, 2022

netlify bot commented Sep 19, 2022 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

codecov bot commented Sep 19, 2022 • edited Loading

Codecov Report

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

nx-cloud bot commented Sep 19, 2022 •

edited

Loading

netlify bot commented Sep 19, 2022 •

edited

Loading

codecov bot commented Sep 19, 2022 •

edited

Loading