Skip to content

docs: add description of resolution order of parserOptions.project #5682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 26, 2022
Merged

docs: add description of resolution order of parserOptions.project #5682

merged 3 commits into from
Sep 26, 2022

Conversation

kazizi55
Copy link
Contributor

@kazizi55 kazizi55 commented Sep 24, 2022 •
edited
Loading

PR Checklist

Overview

  • add description of resolution order of parserOptions.project

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kazizi55!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Sep 24, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 74d7888. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Sep 24, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 74d7888
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6331a4ec456d8d0008c07f97
😎 Deploy Preview https://deploy-preview-5682--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kazizi55 kazizi55 marked this pull request as ready for review September 24, 2022 11:59
JoshuaKGoldberg
JoshuaKGoldberg requested changes Sep 24, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start! 🚀

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Sep 24, 2022
@codecov
Copy link

codecov bot commented Sep 26, 2022 •
edited
Loading

Codecov Report

Merging #5682 (74d7888) into main (23b92c9) will increase coverage by 2.81%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5682      +/-   ##
==========================================
+ Coverage   91.01%   93.82%   +2.81%     
==========================================
  Files         365      134     -231     
  Lines       11962     1506   -10456     
  Branches     3483      226    -3257     
==========================================
- Hits        10887     1413    -9474     
+ Misses        781       60     -721     
+ Partials      294       33     -261
Flag Coverage Δ
unittest 93.82% <ø> (+2.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/eslint-plugin/src/rules/default-param-last.ts
...ackages/eslint-plugin/src/rules/no-extra-parens.ts
...estree/src/create-program/createIsolatedProgram.ts
...ils/src/ast-utils/eslint-utils/ReferenceTracker.ts
packages/eslint-plugin/src/configs/base.ts
...slint-plugin/src/rules/prefer-enum-initializers.ts
...plugin/src/rules/explicit-module-boundary-types.ts
packages/eslint-plugin/src/rules/no-extra-semi.ts
...slint-plugin/src/rules/no-duplicate-enum-values.ts
packages/utils/src/ts-eslint-scope/index.ts
... and 221 more

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks for the collaboration @kazizi55! 🙌

@JoshuaKGoldberg JoshuaKGoldberg merged commit 25d035b into typescript-eslint:main Sep 26, 2022
@kazizi55 kazizi55 deleted the add-resolution-order-of-parserOption-project branch September 26, 2022 17:34
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Oct 6, 2022
Closed
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
awaiting response Issues waiting for a reply from the OP or another party
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazizi55 @JoshuaKGoldberg