☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4f1cbd7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Sent with 💌 from NxCloud.

Thanks for the PR, @varwasabi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

❌ Deploy Preview for typescript-eslint failed.

Codecov Report

Merging #5689 (cffe5d3) into main (84e316b) will increase coverage by 0.00%.
The diff coverage is 55.43%.

❗ Current head cffe5d3 differs from pull request most recent head 4f1cbd7. Consider uploading reports for the commit 4f1cbd7 to get more accurate results

@@            Coverage Diff            @@
##             main    #5689     +/-   ##
=========================================
  Coverage   91.01%   91.02%             
=========================================
  Files         365      348     -17     
  Lines       11962    10203   -1759     
  Branches     3483     3053    -430     
=========================================
- Hits        10887     9287   -1600     
+ Misses        781      657    -124     
+ Partials      294      259     -35     

Any update on this PR?

👋 @varwasabi! I forked tsutils into https://github.com/JoshuaKGoldberg/ts-api-tools and have a replacement PR here: #6428. We really appreciate your work on this PR, but don't think it's in our best interest to continue with it. Thanks so much - and I hope you work on more contributions for typescript-eslint! ❤️

More explanation: I long term don't think we want to be in the business of maintaining a fork of  tsutils in this repo. tsutils has a lot in it and we're already stretched pretty thin in this repository. This PR is over 1k lines added - which isn't a huge amount of code, but still adds a cost.

If we were the only users of tsutils then it'd be pretty reasonable for us to just use it internally and/or as an addition to @typescript-eslint/type-utils. But tsutils is used by a lot of folks. What'd be healthiest for its many consumers is to have a version of it that's actually updated & usable. Hence the hard fork to ts-api-tools.

I'll note that #6428 is still in review right now and ts-api-tools is very new. If it ends up that I'm wrong and we do want to maintain copies of the many tsutils functions in packages/type-utils, then we can certainly reopen this PR - and I can help get it through.

Cheers!