Skip to content

feat: support parsing satisfies operators #5717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Nov 18, 2022
Merged

feat: support parsing satisfies operators #5717

merged 18 commits into from
Nov 18, 2022

Conversation

sosukesuzuki
Copy link
Contributor

@sosukesuzuki sosukesuzuki commented Oct 2, 2022 •
edited by bradzacher
Loading

PR Checklist

Overview

Based on #5716
Adds parsing support for satisfies operator.

@nx-cloud
Copy link

nx-cloud bot commented Oct 2, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5419dea. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Oct 2, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 5419dea
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6376cf6ce6dcb20008cf4637
😎 Deploy Preview https://deploy-preview-5717--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sosukesuzuki sosukesuzuki force-pushed the support-satisfies-operators branch from d60f18b to 3f346d6 Compare October 2, 2022 17:07
@codecov
Copy link

codecov bot commented Oct 2, 2022 •
edited
Loading

Codecov Report

Merging #5717 (94fbc45) into main (a40a311) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 94fbc45 differs from pull request most recent head 5419dea. Consider uploading reports for the commit 5419dea to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5717   +/-   ##
=======================================
  Coverage   91.29%   91.29%           
=======================================
  Files         366      366           
  Lines       12347    12348    +1     
  Branches     3610     3610           
=======================================
+ Hits        11272    11273    +1     
  Misses        767      767           
  Partials      308      308
Flag Coverage Δ
unittest 91.29% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/visitor-keys/src/visitor-keys.ts 100.00% <ø> (ø)
packages/typescript-estree/src/convert.ts 97.89% <100.00%> (+<0.01%) ⬆️

@sosukesuzuki sosukesuzuki force-pushed the support-satisfies-operators branch from 599ac1a to 2ea0aac Compare November 2, 2022 10:45
@sosukesuzuki sosukesuzuki mentioned this pull request Nov 4, 2022
Merged
2 tasks
This was referenced Nov 17, 2022
Closed
Merged
JoshuaKGoldberg
JoshuaKGoldberg reviewed Nov 17, 2022
View reviewed changes
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review November 17, 2022 17:35
bradzacher
bradzacher approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

thankss

For reference, changes I made prior to merging:

  • update babel packages so it supports the satisfies operator
  • converted the fixture test from a "shared fixtures" test to a new and shiny "ast-spec" test.
    • this is the preferred way of doing these ast tests going forward as we can more easily split them, compare with babel etc

@bradzacher bradzacher enabled auto-merge (squash) November 18, 2022 00:32
@bradzacher bradzacher merged commit 20d7cae into typescript-eslint:main Nov 18, 2022
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Nov 18, 2022
Closed
2 tasks
This was referenced Nov 18, 2022
Closed
Closed
@sosukesuzuki sosukesuzuki deleted the support-satisfies-operators branch November 20, 2022 04:30
@obulat obulat mentioned this pull request Nov 21, 2022
Merged
7 tasks
@bradzacher bradzacher mentioned this pull request Nov 22, 2022
Merged
3 tasks
omril1 pushed a commit to omril1/typescript-eslint that referenced this pull request Nov 23, 2022
@sosukesuzuki @JoshuaKGoldberg @bradzacher
feat: support parsing satisfies operators (typescript-eslint#5717)
cc03e7e 
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sosukesuzuki @JoshuaKGoldberg @bradzacher