feat(eslint-plugin): add rule strict-boolean-expressions #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-f1
reviewed
Jun 2, 2019
jonathanrdelgado
commented
Jun 2, 2019
jonathanrdelgado
commented
Jun 2, 2019
JamesHenry
previously approved these changes
Jun 20, 2019
bradzacher
requested changes
Jun 27, 2019
Codecov Report
@@ Coverage Diff @@
## master #579 +/- ##
==========================================
+ Coverage 94.33% 94.36% +0.02%
==========================================
Files 109 110 +1
Lines 4540 4560 +20
Branches 1254 1258 +4
==========================================
+ Hits 4283 4303 +20
Misses 149 149
Partials 108 108
|
- Add support for generics - Abstract Logical/Unary expressions - Abstract reports for multiple calls - Filter UnaryExpressions at the walker
|
Thank you for the specific feedback and suggestions, it was very helpful! |
bradzacher
approved these changes
Jul 1, 2019
|
It's kinda useless without the Edit: At least until we get nullish coalescing operator |
|
Someone else has PR'd it #691 Also, please don't leave comments on closed PRs. It's unnecessary notification spam that serves zero purpose. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ported over the strict-boolean-expressions rule from TSLint. I made the conscious decision to not move the previous options, as I felt they directly contradicted the rule itself.
For quick reference: https://palantir.github.io/tslint/rules/strict-boolean-expressions
This was my first implementation of an ESLint rule, so I am very open to any and all feedback. Thank you for your time!