Skip to content

chore: add automation for @nrwl + nx package updates #5797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Conversation

JamesHenry
Copy link
Member

@JamesHenry JamesHenry commented Oct 10, 2022

I have been using this approach very successfully for a while on angular-eslint

E.g. angular-eslint/angular-eslint#1135

Nx has its own powerful built in migration tool nx migrate, which will update relevant packages (therefore those are added to ignore in renovate config) and even run required code and config migrations (codemods) if applicable.

Here you can see an example of such automatic config updates: #5798

@nx-cloud
Copy link

nx-cloud bot commented Oct 10, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 57317b1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JamesHenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Oct 10, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 57317b1
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/637c89dcb9c7e90008c09f23
😎 Deploy Preview https://deploy-preview-5797--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@@ -86,6 +86,7 @@
"eslint-plugin-import": "^2.26.0",
"eslint-plugin-jest": "^26.1.5",
"eslint-plugin-simple-import-sort": "^8.0.0",
"execa": "5.1.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinned to the last non-ESM version

@JamesHenry JamesHenry marked this pull request as ready for review November 22, 2022 08:40
@JamesHenry
Copy link
Member Author

Netlify redirect rules check seems stuck...

@bradzacher
Copy link
Member

whatugot

@bradzacher bradzacher merged commit 6de4a9a into main Nov 23, 2022
@bradzacher bradzacher deleted the auto-nx-migrate branch November 23, 2022 23:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants